Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Chao Fan
On Fri, Dec 07, 2018 at 10:50:21AM +0800, Baoquan He wrote: >On 12/07/18 at 10:10am, Baoquan He wrote: >> Hi, >> >> On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: >> > > diff --git a/arch/x86/boot/compressed/misc.c >> > > b/arch/x86/boot/compressed/misc.c >> > > index 8dd1d5ccae58..e51713fe3add

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Chao Fan
On Fri, Dec 07, 2018 at 10:50:21AM +0800, Baoquan He wrote: >On 12/07/18 at 10:10am, Baoquan He wrote: >> Hi, >> >> On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: >> > > diff --git a/arch/x86/boot/compressed/misc.c >> > > b/arch/x86/boot/compressed/misc.c >> > > index 8dd1d5ccae58..e51713fe3add

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Baoquan He
On 12/07/18 at 10:10am, Baoquan He wrote: > Hi, > > On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: > > > diff --git a/arch/x86/boot/compressed/misc.c > > > b/arch/x86/boot/compressed/misc.c > > > index 8dd1d5ccae58..e51713fe3add 100644 > > > --- a/arch/x86/boot/compressed/misc.c > > > +++

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Baoquan He
On 12/07/18 at 10:10am, Baoquan He wrote: > Hi, > > On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: > > > diff --git a/arch/x86/boot/compressed/misc.c > > > b/arch/x86/boot/compressed/misc.c > > > index 8dd1d5ccae58..e51713fe3add 100644 > > > --- a/arch/x86/boot/compressed/misc.c > > > +++

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Baoquan He
Hi, On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: > > diff --git a/arch/x86/boot/compressed/misc.c > > b/arch/x86/boot/compressed/misc.c > > index 8dd1d5ccae58..e51713fe3add 100644 > > --- a/arch/x86/boot/compressed/misc.c > > +++ b/arch/x86/boot/compressed/misc.c > > @@ -12,6 +12,7 @@ > > *

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Baoquan He
Hi, On 11/29/18 at 04:10pm, Masayoshi Mizuma wrote: > > diff --git a/arch/x86/boot/compressed/misc.c > > b/arch/x86/boot/compressed/misc.c > > index 8dd1d5ccae58..e51713fe3add 100644 > > --- a/arch/x86/boot/compressed/misc.c > > +++ b/arch/x86/boot/compressed/misc.c > > @@ -12,6 +12,7 @@ > > *

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Chao Fan
Hi Boris, Baoquan and Masa, When copying kstrtoull() and functions needed to arch/x86/boot/string.c, I got an error in LD period: LD arch/x86/boot/setup.elf ld: arch/x86/boot/string.o: in function `div_u64_rem': /home/cfan/code/tip/./include/linux/math64.h:28: undefined reference to

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-06 Thread Chao Fan
Hi Boris, Baoquan and Masa, When copying kstrtoull() and functions needed to arch/x86/boot/string.c, I got an error in LD period: LD arch/x86/boot/setup.elf ld: arch/x86/boot/string.o: in function `div_u64_rem': /home/cfan/code/tip/./include/linux/math64.h:28: undefined reference to

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-05 Thread Chao Fan
On Wed, Dec 05, 2018 at 03:58:14PM +0100, Borislav Petkov wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can show

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-05 Thread Chao Fan
On Wed, Dec 05, 2018 at 03:58:14PM +0100, Borislav Petkov wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can show

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-05 Thread Borislav Petkov
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-05 Thread Borislav Petkov
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Chao Fan
On Tue, Dec 04, 2018 at 07:34:00PM +0100, Borislav Petkov wrote: >On Fri, Nov 30, 2018 at 10:29:14AM +0800, Chao Fan wrote: >> Oh, thanks, will change it >> char val[19]; > >And make that 19 a define. I will do that. Thanks, Chao Fan > >-- >Regards/Gruss, >Boris. > >Good mailing practices

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Chao Fan
On Tue, Dec 04, 2018 at 07:34:00PM +0100, Borislav Petkov wrote: >On Fri, Nov 30, 2018 at 10:29:14AM +0800, Chao Fan wrote: >> Oh, thanks, will change it >> char val[19]; > >And make that 19 a define. I will do that. Thanks, Chao Fan > >-- >Regards/Gruss, >Boris. > >Good mailing practices

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Chao Fan
On Tue, Dec 04, 2018 at 07:42:20PM +0100, Borislav Petkov wrote: >On Sat, Dec 01, 2018 at 02:05:39PM +0800, Chao Fan wrote: >> >I built your whole patchset and got the error. >> >The error depends on CONFIG_MODVERSIONS. >> >If CONFIG_MODVERSIONS=y, you will get the build error. >> >> Hi Masa, >>

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Chao Fan
On Tue, Dec 04, 2018 at 07:42:20PM +0100, Borislav Petkov wrote: >On Sat, Dec 01, 2018 at 02:05:39PM +0800, Chao Fan wrote: >> >I built your whole patchset and got the error. >> >The error depends on CONFIG_MODVERSIONS. >> >If CONFIG_MODVERSIONS=y, you will get the build error. >> >> Hi Masa, >>

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Borislav Petkov
On Sat, Dec 01, 2018 at 02:05:39PM +0800, Chao Fan wrote: > >I built your whole patchset and got the error. > >The error depends on CONFIG_MODVERSIONS. > >If CONFIG_MODVERSIONS=y, you will get the build error. > > Hi Masa, > > Thanks, after that, I got the error. > About your solution, it can

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Borislav Petkov
On Sat, Dec 01, 2018 at 02:05:39PM +0800, Chao Fan wrote: > >I built your whole patchset and got the error. > >The error depends on CONFIG_MODVERSIONS. > >If CONFIG_MODVERSIONS=y, you will get the build error. > > Hi Masa, > > Thanks, after that, I got the error. > About your solution, it can

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Borislav Petkov
On Fri, Nov 30, 2018 at 10:29:14AM +0800, Chao Fan wrote: > Oh, thanks, will change it > char val[19]; And make that 19 a define. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-04 Thread Borislav Petkov
On Fri, Nov 30, 2018 at 10:29:14AM +0800, Chao Fan wrote: > Oh, thanks, will change it > char val[19]; And make that 19 a define. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-30 Thread Chao Fan
On Fri, Nov 30, 2018 at 12:35:16PM -0500, Masayoshi Mizuma wrote: >On Fri, Nov 30, 2018 at 10:43:47AM +0800, Chao Fan wrote: >... >> >]$ make arch/x86/boot/compressed/misc.o >> > CALLscripts/checksyscalls.sh >> > DESCEND objtool >> > CC arch/x86/boot/compressed/misc.o >> >ld: -r and

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-30 Thread Chao Fan
On Fri, Nov 30, 2018 at 12:35:16PM -0500, Masayoshi Mizuma wrote: >On Fri, Nov 30, 2018 at 10:43:47AM +0800, Chao Fan wrote: >... >> >]$ make arch/x86/boot/compressed/misc.o >> > CALLscripts/checksyscalls.sh >> > DESCEND objtool >> > CC arch/x86/boot/compressed/misc.o >> >ld: -r and

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-30 Thread Masayoshi Mizuma
On Fri, Nov 30, 2018 at 10:43:47AM +0800, Chao Fan wrote: ... > >]$ make arch/x86/boot/compressed/misc.o > > CALLscripts/checksyscalls.sh > > DESCEND objtool > > CC arch/x86/boot/compressed/misc.o > >ld: -r and -pie may not be used together > >make[1]: *** [scripts/Makefile.build:294:

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-30 Thread Masayoshi Mizuma
On Fri, Nov 30, 2018 at 10:43:47AM +0800, Chao Fan wrote: ... > >]$ make arch/x86/boot/compressed/misc.o > > CALLscripts/checksyscalls.sh > > DESCEND objtool > > CC arch/x86/boot/compressed/misc.o > >ld: -r and -pie may not be used together > >make[1]: *** [scripts/Makefile.build:294:

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
>> + >> +/* acpitb.c */ >> +#define BOOT_STRING >> +extern int kstrtoull(const char *s, unsigned int base, unsigned long long >> *res); >> diff --git a/lib/kstrtox.c b/lib/kstrtox.c >> index 1006bf70bf74..a0ac1b2257b8 100644 >> --- a/lib/kstrtox.c >> +++ b/lib/kstrtox.c >> @@ -126,6 +126,9 @@ int

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
>> + >> +/* acpitb.c */ >> +#define BOOT_STRING >> +extern int kstrtoull(const char *s, unsigned int base, unsigned long long >> *res); >> diff --git a/lib/kstrtox.c b/lib/kstrtox.c >> index 1006bf70bf74..a0ac1b2257b8 100644 >> --- a/lib/kstrtox.c >> +++ b/lib/kstrtox.c >> @@ -126,6 +126,9 @@ int

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 11:20:13AM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
On Thu, Nov 29, 2018 at 11:20:13AM -0500, Masayoshi Mizuma wrote: >On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: >> To fix the conflict between KASLR and memory-hotremove, memory >> information in SRAT table is necessary. >> >> ACPI SRAT (System/Static Resource Affinity Table) can

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

Re: [PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Masayoshi Mizuma
On Thu, Nov 29, 2018 at 04:16:27PM +0800, Chao Fan wrote: > To fix the conflict between KASLR and memory-hotremove, memory > information in SRAT table is necessary. > > ACPI SRAT (System/Static Resource Affinity Table) can show the details > about memory ranges, including ranges of memory

[PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
To fix the conflict between KASLR and memory-hotremove, memory information in SRAT table is necessary. ACPI SRAT (System/Static Resource Affinity Table) can show the details about memory ranges, including ranges of memory provided by hot-added memory devices. SRAT table must be introduced by RSDP

[PATCH v12 1/5] x86/boot: Add get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-11-29 Thread Chao Fan
To fix the conflict between KASLR and memory-hotremove, memory information in SRAT table is necessary. ACPI SRAT (System/Static Resource Affinity Table) can show the details about memory ranges, including ranges of memory provided by hot-added memory devices. SRAT table must be introduced by RSDP