Hi Alim,
On 16-07-20, 06:47, Alim Akhtar wrote:
> > > +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy
> > > +*phy) {
> > > + int ret = 0;
> >
> > superfluous init, am sure I flagged it before as well
> >
> Yes, you did, but 0-DAY CI kernel test gave warning [1], so I kept
el.org; linux-samsung-...@vger.kernel.org; kis...@ti.com
> Subject: Re: [PATCH v12 2/2] phy: samsung-ufs: add UFS PHY driver for
samsung
> SoC
>
> On 03-07-20, 22:41, Alim Akhtar wrote:
>
> > +static const struct samsung_ufs_phy_cfg exynos7_post_init_cfg[] = {
> > + END_UFS
On 03-07-20, 22:41, Alim Akhtar wrote:
> +static const struct samsung_ufs_phy_cfg exynos7_post_init_cfg[] = {
> + END_UFS_PHY_CFG
> +};
This is dummy, why not add a check to make config optional?
> +static int samsung_ufs_phy_symbol_clk_init(struct samsung_ufs_phy *phy)
> +{
> + int ret
Hi Vinod
Gentle Reminder !!
On Fri, Jul 3, 2020 at 11:02 PM Alim Akhtar wrote:
>
> This patch introduces Samsung UFS PHY driver. This driver
> supports to deal with phy calibration and power control
> according to UFS host driver's behavior.
>
> [Robot: -Wmissing-prototypes and
This patch introduces Samsung UFS PHY driver. This driver
supports to deal with phy calibration and power control
according to UFS host driver's behavior.
[Robot: -Wmissing-prototypes and -Wsometimes-uninitialized]
Reported-by: kernel test robot
Reviewed-by: Kiwoong Kim
Signed-off-by: Seungwon
5 matches
Mail list logo
