Re: [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-24 Thread kbuild test robot
Hi Tali, I love your patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v5.7-rc6 next-20200522] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to

Re: [PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-22 Thread Andy Shevchenko
On Fri, May 22, 2020 at 02:33:11PM +0300, Tali Perry wrote: > Add Nuvoton NPCM BMC I2C controller driver. I thought we are waiting for Wolfram finishing his review... In any case see couple of comments below. ... > +#ifdef CONFIG_DEBUG_FS Now, do we need the rest of DEBUG_FS guards? > +

[PATCH v13 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-22 Thread Tali Perry
Add Nuvoton NPCM BMC I2C controller driver. Signed-off-by: Tali Perry Reviewed-by: Andy Shevchenko --- drivers/i2c/busses/Kconfig |9 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-npcm7xx.c | 1804 ++ 3 files changed, 1814