Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-14 Thread Jiri Olsa
On Fri, Oct 12, 2018 at 07:28:23PM +0300, Alexey Budankov wrote: > Hi, > > On 12.10.2018 17:17, Jiri Olsa wrote: > > On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: > > > > SNIP > > > >> @@ -1490,6 +1514,13 @@ static int perf_record_config(const char *var, > >> const char *valu

Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-12 Thread Alexey Budankov
Hi, On 12.10.2018 17:17, Jiri Olsa wrote: > On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: > > SNIP > >> @@ -1490,6 +1514,13 @@ static int perf_record_config(const char *var, const >> char *value, void *cb) >> var = "call-graph.record-mode"; >> return

Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-12 Thread Jiri Olsa
On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: SNIP > @@ -1490,6 +1514,13 @@ static int perf_record_config(const char *var, const > char *value, void *cb) > var = "call-graph.record-mode"; > return perf_default_config(var, value, cb); > } > +#i

Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-12 Thread Alexey Budankov
Hi, On 12.10.2018 12:49, Namhyung Kim wrote: > Hi, > > On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: >> >> @@ -1882,8 +1913,8 @@ static struct option __record_options[] = { >> OPT_BOOLEAN(0, "dry-run", &dry_run, >> "Parse options then exit"), >> #ifdef H

Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-12 Thread Namhyung Kim
Hi, On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: > > Multi AIO trace writing allows caching more kernel data into userspace > memory postponing trace writing for the sake of overall profiling data > thruput increase. It could be seen as kernel data buffer extension into > us

[PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-11 Thread Alexey Budankov
Multi AIO trace writing allows caching more kernel data into userspace memory postponing trace writing for the sake of overall profiling data thruput increase. It could be seen as kernel data buffer extension into userspace memory. With aio option value different from 0, default value is 1, t