Re: [PATCH v14 2/3]: perf record: enable asynchronous trace writing

2018-11-02 Thread Alexey Budankov
Hi, On 01.11.2018 21:42, Song Liu wrote: > On Sun, Oct 14, 2018 at 11:45 PM Alexey Budankov > wrote: >> >> + if (verbose > 0) >> + pr_info("nr_cblocks: %d\n", rec->opts.nr_cblocks); >> + > > nit: I guess we don't really need this pr_info()? Diagnostic aid. Thanks, Alexey

Re: [PATCH v14 2/3]: perf record: enable asynchronous trace writing

2018-11-01 Thread Song Liu
On Sun, Oct 14, 2018 at 11:45 PM Alexey Budankov wrote: > > > Trace file offset is read once before mmaps iterating loop and written > back after all performance data enqueued for aio writing. Trace file offset > is incremented linearly after every successful aio write operation. > > record__aio_s

[PATCH v14 2/3]: perf record: enable asynchronous trace writing

2018-10-14 Thread Alexey Budankov
Trace file offset is read once before mmaps iterating loop and written back after all performance data enqueued for aio writing. Trace file offset is incremented linearly after every successful aio write operation. record__aio_sync() blocks till completion of started AIO operation and then pr