Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Pavel Machek
On Wed 2018-10-24 21:17:25, Jacek Anaszewski wrote: > On 10/24/2018 10:31 AM, Pavel Machek wrote: > > Hi! > > > >>> + > >>> + The gradual dimming format of the software pattern values > >>> should be: > >>> + "brightness_1 duration_1 brightness_2 duration_2 brightness_3 > >>> +

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Jacek Anaszewski
On 10/24/2018 10:31 AM, Pavel Machek wrote: > Hi! > >>> + >>> + The gradual dimming format of the software pattern values >>> should be: >>> + "brightness_1 duration_1 brightness_2 duration_2 brightness_3 >>> + duration_3 ...". For example: >>> + >>> + echo

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Pavel Machek
Hi! > > OK, let's abide by constant update interval for now. > > > > Thank you for your work on this patch set throughout > > all these months. We will have -rc8, so one week of testing > > before sending upstream should be enough. > > > > Patch set applied to the for-next branch of linux-leds.git

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-24 Thread Pavel Machek
Hi! > > + > > + The gradual dimming format of the software pattern values > > should be: > > + "brightness_1 duration_1 brightness_2 duration_2 brightness_3 > > + duration_3 ...". For example: > > + > > + echo 0 1000 255 2000 > pattern > > + > > +

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-11 Thread Baolin Wang
Hi, On 12 October 2018 at 04:07, Jacek Anaszewski wrote: > Hi Baolin, > > On 10/11/2018 06:07 AM, Baolin Wang wrote: >> This patch adds a new led trigger that LED device can employ >> software or hardware pattern engine. >> >> Consumers can write 'pattern' file to enable the software pattern >> w

Re: [PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-11 Thread Jacek Anaszewski
Hi Baolin, On 10/11/2018 06:07 AM, Baolin Wang wrote: > This patch adds a new led trigger that LED device can employ > software or hardware pattern engine. > > Consumers can write 'pattern' file to enable the software pattern > which alters the brightness for the specified duration with one > sof

[PATCH v15 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Baolin Wang
This patch adds a new led trigger that LED device can employ software or hardware pattern engine. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write 'hw_pattern' file to ena