Re: [PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
Hi Anand,
On 05.11.2020 09:06, Anand Moon wrote:
> On Mon, 2 Nov 2020 at 21:53, Marek Szyprowski
> wrote:
>> On 01.11.2020 15:07, Anand Moon wrote:
>>> On Thu, 1 Oct 2020 at 19:25, Łukasz Stelmach wrote:
Add a placeholder for a MAC address. A bootloader may fill it
to set the MAC address and override EEPROM settings.
Signed-off-by: Łukasz Stelmach
---
Changes in v2:
- use local-mac-address and leave mac-address to be added by a
bootloader
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index db0bc17a667b..d0f6ac5fa79d 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -70,3 +70,21 @@ {
_dwc3_1 {
dr_mode = "peripheral";
};
+
+ {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb8087,0024";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@1 {
+ compatible = "usb0c45,6310";
+ reg = <1>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled
in by a bootloader */
+ };
+ };
+};
--
2.26.2
>>> Thanks for this patch, can you share some example on how to set the
>>> mac address via u-boot bootargs
>> A little bit hacky script to set permanent board unique MAC address:
>>
>> # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
>> *0x1016; setexp.b u3 *0x1017; setenv ethaddr
>> 0:0:${u0}:${u1}:${u2}:${u3}; setenv usbethaddr ${ethaddr};
>>
> OK this command worked for me.
>
>> Then if there is proper ethernet0 alias set, u-boot will then
>> automatically save the configured MAC address to the device tree. I've
>> just check this on recent u-boot v2020.10 and Odroid U3 board.
>>
>> Lukasz will send updated patch soon (with proper alias entry).
>>
>> If you want to hack setting MAC address manually, this will work with
>> the current patch:
>>
>> # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
>> *0x1016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
>> /soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
>> ${u2} ${u3} ]
>>
> So do we need a similar patch for u-boot ?
I've not sure that this ethaddr hack/workaround should be added to
mainline uboot. Some other exynos based board have proper MAC address
stored in EEPROM (for example Odroid XU4/HC1). I would leave it for the
users to add it manually if it is really needed for now.
> I am getting following error on Odroid U3+ and U-Boot 2020.10
>
> Odroid # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b
> u2 *0x1016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
> /soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
> ${u2} ${u3} ]
> No FDT memory address configured. Please configure
> the FDT address via "fdt addr " command.
> Aborting!
>
> Also added these command to boot.scr but still observing the failure
You need to use proper env for setting fdt address (the "fdt addr
${fdtaddr}" command). For some versions it was ${fdt_addr}, the other
used ${fdtaddr}. Please check which one is used for loading dtb and
adjust the script.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Re: [PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
Hi Marek,
On Mon, 2 Nov 2020 at 21:53, Marek Szyprowski wrote:
>
> Hi Anand,
>
> On 01.11.2020 15:07, Anand Moon wrote:
> > Hi Lukasz,
> >
> > On Thu, 1 Oct 2020 at 19:25, Łukasz Stelmach wrote:
> >> Add a placeholder for a MAC address. A bootloader may fill it
> >> to set the MAC address and override EEPROM settings.
> >>
> >> Signed-off-by: Łukasz Stelmach
> >> ---
> >> Changes in v2:
> >> - use local-mac-address and leave mac-address to be added by a bootloader
> >>
> >> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> index db0bc17a667b..d0f6ac5fa79d 100644
> >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> @@ -70,3 +70,21 @@ {
> >> _dwc3_1 {
> >> dr_mode = "peripheral";
> >> };
> >> +
> >> + {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + hub@1 {
> >> + compatible = "usb8087,0024";
> >> + reg = <1>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + ethernet: usbether@1 {
> >> + compatible = "usb0c45,6310";
> >> + reg = <1>;
> >> + local-mac-address = [00 00 00 00 00 00]; /* Filled
> >> in by a bootloader */
> >> + };
> >> + };
> >> +};
> >> --
> >> 2.26.2
> >>
> > Thanks for this patch, can you share some example on how to set the
> > mac address via u-boot bootargs
>
> A little bit hacky script to set permanent board unique MAC address:
>
> # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
> *0x1016; setexp.b u3 *0x1017; setenv ethaddr
> 0:0:${u0}:${u1}:${u2}:${u3}; setenv usbethaddr ${ethaddr};
>
OK this command worked for me.
> Then if there is proper ethernet0 alias set, u-boot will then
> automatically save the configured MAC address to the device tree. I've
> just check this on recent u-boot v2020.10 and Odroid U3 board.
>
> Lukasz will send updated patch soon (with proper alias entry).
>
> If you want to hack setting MAC address manually, this will work with
> the current patch:
>
> # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
> *0x1016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
> /soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
> ${u2} ${u3} ]
>
So do we need a similar patch for u-boot ?
I am getting following error on Odroid U3+ and U-Boot 2020.10
Odroid # setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b
u2 *0x1016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
/soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
${u2} ${u3} ]
No FDT memory address configured. Please configure
the FDT address via "fdt addr " command.
Aborting!
Also added these command to boot.scr but still observing the failure
mmc0(part 0) is current device
Scanning mmc 0:1...
Found U-Boot script /boot/boot.scr
969 bytes read in 5 ms (188.5 KiB/s)
## Executing script at 4200
7341440 bytes read in 265 ms (26.4 MiB/s)
53875 bytes read in 56 ms (939.5 KiB/s)
7964187 bytes read in 285 ms (26.6 MiB/s)
libfdt fdt_path_offset() returned FDT_ERR_NOTFOUND
Kernel image @ 0x4100 [ 0x00 - 0x700580 ]
## Flattened Device Tree blob at 4080
Booting using the fdt blob at 0x4080
Loading Ramdisk to 4f867000, end 461b ... OK
Loading Device Tree to 4f856000, end 4f866272 ... OK
,
Best Regards
-Anand
> > also can you update this patch for exynos5422-odroidxu3-lite.dts and
> > exynos4412-odroidu3.dts.
>
> Also odroid-x2 and odroid-xu. Lukasz will take care of them.
>
> Best regards
>
> --
> Marek Szyprowski, PhD
> Samsung R Institute Poland
>
Re: [PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
Hi Anand,
On 01.11.2020 15:07, Anand Moon wrote:
> Hi Lukasz,
>
> On Thu, 1 Oct 2020 at 19:25, Łukasz Stelmach wrote:
>> Add a placeholder for a MAC address. A bootloader may fill it
>> to set the MAC address and override EEPROM settings.
>>
>> Signed-off-by: Łukasz Stelmach
>> ---
>> Changes in v2:
>> - use local-mac-address and leave mac-address to be added by a bootloader
>>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++
>> 1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index db0bc17a667b..d0f6ac5fa79d 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -70,3 +70,21 @@ {
>> _dwc3_1 {
>> dr_mode = "peripheral";
>> };
>> +
>> + {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + hub@1 {
>> + compatible = "usb8087,0024";
>> + reg = <1>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ethernet: usbether@1 {
>> + compatible = "usb0c45,6310";
>> + reg = <1>;
>> + local-mac-address = [00 00 00 00 00 00]; /* Filled
>> in by a bootloader */
>> + };
>> + };
>> +};
>> --
>> 2.26.2
>>
> Thanks for this patch, can you share some example on how to set the
> mac address via u-boot bootargs
A little bit hacky script to set permanent board unique MAC address:
# setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
*0x1016; setexp.b u3 *0x1017; setenv ethaddr
0:0:${u0}:${u1}:${u2}:${u3}; setenv usbethaddr ${ethaddr};
Then if there is proper ethernet0 alias set, u-boot will then
automatically save the configured MAC address to the device tree. I've
just check this on recent u-boot v2020.10 and Odroid U3 board.
Lukasz will send updated patch soon (with proper alias entry).
If you want to hack setting MAC address manually, this will work with
the current patch:
# setexp.b u0 *0x1014; setexp.b u1 *0x1015; setexp.b u2
*0x1016; setexp.b u3 *0x1017; fdt addr ${fdtaddr}; fdt set
/soc/usb@1211/hub@1/usbether@1 local-mac-address [ 0 0 ${u0} ${u1}
${u2} ${u3} ]
> also can you update this patch for exynos5422-odroidxu3-lite.dts and
> exynos4412-odroidu3.dts.
Also odroid-x2 and odroid-xu. Lukasz will take care of them.
Best regards
--
Marek Szyprowski, PhD
Samsung R Institute Poland
Re: [PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
Hi Lukasz,
On Thu, 1 Oct 2020 at 19:25, Łukasz Stelmach wrote:
>
> Add a placeholder for a MAC address. A bootloader may fill it
> to set the MAC address and override EEPROM settings.
>
> Signed-off-by: Łukasz Stelmach
> ---
> Changes in v2:
> - use local-mac-address and leave mac-address to be added by a bootloader
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index db0bc17a667b..d0f6ac5fa79d 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -70,3 +70,21 @@ {
> _dwc3_1 {
> dr_mode = "peripheral";
> };
> +
> + {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hub@1 {
> + compatible = "usb8087,0024";
> + reg = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethernet: usbether@1 {
> + compatible = "usb0c45,6310";
> + reg = <1>;
> + local-mac-address = [00 00 00 00 00 00]; /* Filled in
> by a bootloader */
> + };
> + };
> +};
> --
> 2.26.2
>
Thanks for this patch, can you share some example on how to set the
mac address via u-boot bootargs
also can you update this patch for exynos5422-odroidxu3-lite.dts and
exynos4412-odroidu3.dts.
Best Regards
-Anand
Re: [PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
On Thu, Oct 01, 2020 at 03:52:54PM +0200, Łukasz Stelmach wrote: > Add a placeholder for a MAC address. A bootloader may fill it > to set the MAC address and override EEPROM settings. > > Signed-off-by: Łukasz Stelmach > --- > Changes in v2: > - use local-mac-address and leave mac-address to be added by a bootloader > > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++ > 1 file changed, 18 insertions(+) Thanks, applied. Best regards, Krzysztof
[PATCH v2] ARM: dts: exynos: Add a placeholder for a MAC address
Add a placeholder for a MAC address. A bootloader may fill it
to set the MAC address and override EEPROM settings.
Signed-off-by: Łukasz Stelmach
---
Changes in v2:
- use local-mac-address and leave mac-address to be added by a bootloader
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index db0bc17a667b..d0f6ac5fa79d 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -70,3 +70,21 @@ {
_dwc3_1 {
dr_mode = "peripheral";
};
+
+ {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hub@1 {
+ compatible = "usb8087,0024";
+ reg = <1>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet: usbether@1 {
+ compatible = "usb0c45,6310";
+ reg = <1>;
+ local-mac-address = [00 00 00 00 00 00]; /* Filled in
by a bootloader */
+ };
+ };
+};
--
2.26.2
