Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-14 Thread Jessica Yu
+++ Vincent Whitchurch [09/11/18 14:53 +0100]: On Fri, Nov 02, 2018 at 02:53:22PM +0100, Jessica Yu wrote: +++ Vincent Whitchurch [01/11/18 16:29 +0100]: > On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > > Could this be done in modpost? I'm guessing the answer is no as some > >

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-14 Thread Jessica Yu
+++ Vincent Whitchurch [09/11/18 14:53 +0100]: On Fri, Nov 02, 2018 at 02:53:22PM +0100, Jessica Yu wrote: +++ Vincent Whitchurch [01/11/18 16:29 +0100]: > On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > > Could this be done in modpost? I'm guessing the answer is no as some > >

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-09 Thread Vincent Whitchurch
On Fri, Nov 02, 2018 at 02:53:22PM +0100, Jessica Yu wrote: > +++ Vincent Whitchurch [01/11/18 16:29 +0100]: > > On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > > > Could this be done in modpost? I'm guessing the answer is no as some > > > relocations may rely on that bit being set

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-09 Thread Vincent Whitchurch
On Fri, Nov 02, 2018 at 02:53:22PM +0100, Jessica Yu wrote: > +++ Vincent Whitchurch [01/11/18 16:29 +0100]: > > On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > > > Could this be done in modpost? I'm guessing the answer is no as some > > > relocations may rely on that bit being set

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-02 Thread Jessica Yu
+++ Vincent Whitchurch [01/11/18 16:29 +0100]: On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: Could this be done in modpost? I'm guessing the answer is no as some relocations may rely on that bit being set in st_value, right? Therefore we can only clear the bit _after_ relocations

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-02 Thread Jessica Yu
+++ Vincent Whitchurch [01/11/18 16:29 +0100]: On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: Could this be done in modpost? I'm guessing the answer is no as some relocations may rely on that bit being set in st_value, right? Therefore we can only clear the bit _after_ relocations

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-01 Thread Vincent Whitchurch
On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > Could this be done in modpost? I'm guessing the answer is no as some > relocations may rely on that bit being set in st_value, right? > Therefore we can only clear the bit _after_ relocations to the module > are applied at runtime,

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-11-01 Thread Vincent Whitchurch
On Wed, Oct 31, 2018 at 04:53:41PM +0100, Jessica Yu wrote: > Could this be done in modpost? I'm guessing the answer is no as some > relocations may rely on that bit being set in st_value, right? > Therefore we can only clear the bit _after_ relocations to the module > are applied at runtime,

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Jessica Yu
+++ Vincent Whitchurch [31/10/18 09:42 +0100]: Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux |

Re: [PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Jessica Yu
+++ Vincent Whitchurch [31/10/18 09:42 +0100]: Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux |

[PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Vincent Whitchurch
Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux | grep show_interrupts 95947: 8015dc89 686 FUNC

[PATCH v2] ARM: module: Fix function kallsyms on Thumb-2

2018-10-31 Thread Vincent Whitchurch
Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux | grep show_interrupts 95947: 8015dc89 686 FUNC