Re: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

2015-02-02 Thread Robert Jarzmik
Robert Jarzmik writes: > @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i) > void pxa_mask_irq(struct irq_data *d) > { > void __iomem *base = irq_data_get_irq_chip_data(d); > + irq_hw_number_t irq = irqd_to_hwirq(d); > uint32_t icmr = __raw_readl(base + ICMR); >

Re: [PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

2015-02-02 Thread Robert Jarzmik
Robert Jarzmik robert.jarz...@free.fr writes: @@ -66,18 +67,20 @@ static inline void __iomem *irq_base(int i) void pxa_mask_irq(struct irq_data *d) { void __iomem *base = irq_data_get_irq_chip_data(d); + irq_hw_number_t irq = irqd_to_hwirq(d); uint32_t icmr =

[PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

2015-02-01 Thread Robert Jarzmik
The commit "ARM: pxa: arbitrarily set first interrupt number" changed the first pxa interrupt to 16. As a consequence, device-tree builds got broken, because : - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT() - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0) Before the

[PATCH v2] ARM: pxa: fix pxa interrupts handling in DT

2015-02-01 Thread Robert Jarzmik
The commit ARM: pxa: arbitrarily set first interrupt number changed the first pxa interrupt to 16. As a consequence, device-tree builds got broken, because : - pxa_mask_irq() and pxa_unmask_irq() are using IRQ_BIT() - IRQ_BIT(x) calculates the interrupts as : x - PXA_IRQ(0) Before the commit,