Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Stephan Mueller
Am Freitag, 5. September 2014, 15:55:49 schrieb Herbert Xu: Hi Herbert, >On Thu, Sep 04, 2014 at 01:50:32AM +0200, Stephan Mueller wrote: >> Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: >> >> Hi Herbert, >> >> > On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote:

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Herbert Xu
On Mon, Sep 01, 2014 at 07:11:20AM +0200, Stephan Mueller wrote: > The drbg_healthcheck() contained a test to call the DRBG with an > uninitialized DRBG cipher handle. As this is an inappropriate use of the > kernel crypto API to try to generate random numbers before > initialization, checks

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Herbert Xu
On Thu, Sep 04, 2014 at 01:50:32AM +0200, Stephan Mueller wrote: > Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: > > Hi Herbert, > > > On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: > > > Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: > > > >

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Herbert Xu
On Thu, Sep 04, 2014 at 01:50:32AM +0200, Stephan Mueller wrote: Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: Hi Herbert, On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: Hi Herbert,

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Herbert Xu
On Mon, Sep 01, 2014 at 07:11:20AM +0200, Stephan Mueller wrote: The drbg_healthcheck() contained a test to call the DRBG with an uninitialized DRBG cipher handle. As this is an inappropriate use of the kernel crypto API to try to generate random numbers before initialization, checks verifying

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-05 Thread Stephan Mueller
Am Freitag, 5. September 2014, 15:55:49 schrieb Herbert Xu: Hi Herbert, On Thu, Sep 04, 2014 at 01:50:32AM +0200, Stephan Mueller wrote: Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: Hi Herbert, On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: Am

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-03 Thread Stephan Mueller
Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: Hi Herbert, > On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: > > Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: > > > > Hi Herbert, > > > > may I ask for consideration of this patch as this covers

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-03 Thread Herbert Xu
On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: > Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: > > Hi Herbert, > > may I ask for consideration of this patch as this covers an oops FIPS mode? > > In addition, may I ask for guidance on how to fix the 32 bit

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-03 Thread Herbert Xu
On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: Hi Herbert, may I ask for consideration of this patch as this covers an oops FIPS mode? In addition, may I ask for guidance on how to fix the 32 bit code path

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-03 Thread Stephan Mueller
Am Donnerstag, 4. September 2014, 07:21:29 schrieb Herbert Xu: Hi Herbert, On Wed, Sep 03, 2014 at 03:33:16AM +0200, Stephan Mueller wrote: Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: Hi Herbert, may I ask for consideration of this patch as this covers an oops

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-02 Thread Stephan Mueller
Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: Hi Herbert, may I ask for consideration of this patch as this covers an oops FIPS mode? In addition, may I ask for guidance on how to fix the 32 bit code path in Linus' tree as asked on 28.8? To quote: "Thus, the fix in

Re: [PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-09-02 Thread Stephan Mueller
Am Montag, 1. September 2014, 07:11:20 schrieb Stephan Mueller: Hi Herbert, may I ask for consideration of this patch as this covers an oops FIPS mode? In addition, may I ask for guidance on how to fix the 32 bit code path in Linus' tree as asked on 28.8? To quote: Thus, the fix in

[PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-08-31 Thread Stephan Mueller
The drbg_healthcheck() contained a test to call the DRBG with an uninitialized DRBG cipher handle. As this is an inappropriate use of the kernel crypto API to try to generate random numbers before initialization, checks verifying for an initialized DRBG have been removed in previous patches. Now,

[PATCH v2] DRBG: remove check for uninitialized DRBG handle

2014-08-31 Thread Stephan Mueller
The drbg_healthcheck() contained a test to call the DRBG with an uninitialized DRBG cipher handle. As this is an inappropriate use of the kernel crypto API to try to generate random numbers before initialization, checks verifying for an initialized DRBG have been removed in previous patches. Now,