Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Ard Biesheuvel
On 2 November 2016 at 13:56, Eugene Korenevsky wrote: >> > *e820ext is always NULL in 'alloc_e820ext()' (see the code of >> > 'exit_boot()'). >> > Without loss of generality we can replace freeing with returning >> > EFI_INVALID_PARAMETER. So if the caller would ever

Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Ard Biesheuvel
On 2 November 2016 at 13:56, Eugene Korenevsky wrote: >> > *e820ext is always NULL in 'alloc_e820ext()' (see the code of >> > 'exit_boot()'). >> > Without loss of generality we can replace freeing with returning >> > EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass >> >

Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Eugene Korenevsky
> > *e820ext is always NULL in 'alloc_e820ext()' (see the code of > > 'exit_boot()'). > > Without loss of generality we can replace freeing with returning > > EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL > > *e820ext, he will obtain a returned error code. > > > >

Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Eugene Korenevsky
> > *e820ext is always NULL in 'alloc_e820ext()' (see the code of > > 'exit_boot()'). > > Without loss of generality we can replace freeing with returning > > EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL > > *e820ext, he will obtain a returned error code. > > > >

Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Ard Biesheuvel
Hello Eugene, On 2 November 2016 at 04:18, Eugene Korenevsky wrote: > *e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()'). > Without loss of generality we can replace freeing with returning > EFI_INVALID_PARAMETER. So if the caller would ever

Re: [PATCH v2] EFI loader: remove redundant code

2016-11-02 Thread Ard Biesheuvel
Hello Eugene, On 2 November 2016 at 04:18, Eugene Korenevsky wrote: > *e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()'). > Without loss of generality we can replace freeing with returning > EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL >

[PATCH v2] EFI loader: remove redundant code

2016-11-01 Thread Eugene Korenevsky
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()'). Without loss of generality we can replace freeing with returning EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL *e820ext, he will obtain a returned error code. ---

[PATCH v2] EFI loader: remove redundant code

2016-11-01 Thread Eugene Korenevsky
*e820ext is always NULL in 'alloc_e820ext()' (see the code of 'exit_boot()'). Without loss of generality we can replace freeing with returning EFI_INVALID_PARAMETER. So if the caller would ever incorrectly pass non-NULL *e820ext, he will obtain a returned error code. ---