Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-27 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: > On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: > > On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: > > > On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > > > > "Creation, replacement and

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-27 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction of

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-26 Thread Peter Hutterer
On Fri, Apr 24, 2015 at 08:26:39AM +0200, Henrik Rydberg wrote: > Peter, > > It may be a long time ago now, but we had very vocal discussions regarding the > MT protocol back then, and I am quite sure all the subtleties are well > understood. In order to fully appreciate the simplicity of the

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-26 Thread Peter Hutterer
On Fri, Apr 24, 2015 at 08:26:39AM +0200, Henrik Rydberg wrote: Peter, It may be a long time ago now, but we had very vocal discussions regarding the MT protocol back then, and I am quite sure all the subtleties are well understood. In order to fully appreciate the simplicity of the

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-24 Thread Henrik Rydberg
Peter, It may be a long time ago now, but we had very vocal discussions regarding the MT protocol back then, and I am quite sure all the subtleties are well understood. In order to fully appreciate the simplicity of the protocol, one only needs to stop misintepreting it. In order to do that,

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-24 Thread Henrik Rydberg
Peter, It may be a long time ago now, but we had very vocal discussions regarding the MT protocol back then, and I am quite sure all the subtleties are well understood. In order to fully appreciate the simplicity of the protocol, one only needs to stop misintepreting it. In order to do that,

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Peter Hutterer
On Thu, Apr 23, 2015 at 11:47:09AM -0700, Dmitry Torokhov wrote: > On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: > > On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: > > > On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > > > > "Creation, replacement

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Henrik Rydberg
> My guess is that none of these drivers are > able to handle a silent closing of a slot and the easiest solution might > be to simply change the documentation if in fact nobody uses the > compressed notation (which removes just one ABS_SLOT event within the > frame, so not sure we can call it

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: > On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: > > On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > > > "Creation, replacement and destruction of contacts is achieved by > > > > modifying the

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: > On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > > "Creation, replacement and destruction of contacts is achieved by > > > modifying the ABS_MT_TRACKING_ID of the associated slot. A > > > non-negative tracking id is

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > "Creation, replacement and destruction of contacts is achieved by > > modifying the ABS_MT_TRACKING_ID of the associated slot. A > > non-negative tracking id is interpreted as a contact, and the value -1 > > denotes an unused

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Henrik Rydberg
> "Creation, replacement and destruction of contacts is achieved by > modifying the ABS_MT_TRACKING_ID of the associated slot. A > non-negative tracking id is interpreted as a contact, and the value -1 > denotes an unused slot. A tracking id not previously present is > considered new, and a

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Tue, Apr 7, 2015 at 6:17 AM, Jiri Kosina wrote: > On Mon, 6 Apr 2015, Dmitry Torokhov wrote: > >> > With >> > https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-4.1/wacom=9a1c001298fd567c0f0776ab54ab9965eeb9019f >> > in Jiri's tree, scheduled for 4.1, this patch should

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Henrik Rydberg
Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of the associated slot. A non-negative tracking id is interpreted as a contact, and the value -1 denotes an unused slot. A tracking id not previously present is considered new, and a tracking

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Benjamin Tissoires
On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of the associated slot. A non-negative tracking id is interpreted as a

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and destruction of contacts is achieved by modifying the ABS_MT_TRACKING_ID of the associated slot. A non-negative tracking id is interpreted as a contact, and the value -1 denotes an unused slot. A

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Henrik Rydberg
My guess is that none of these drivers are able to handle a silent closing of a slot and the easiest solution might be to simply change the documentation if in fact nobody uses the compressed notation (which removes just one ABS_SLOT event within the frame, so not sure we can call it

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Dmitry Torokhov
On Tue, Apr 7, 2015 at 6:17 AM, Jiri Kosina jkos...@suse.cz wrote: On Mon, 6 Apr 2015, Dmitry Torokhov wrote: With https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-4.1/wacomid=9a1c001298fd567c0f0776ab54ab9965eeb9019f in Jiri's tree, scheduled for 4.1, this patch

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-23 Thread Peter Hutterer
On Thu, Apr 23, 2015 at 11:47:09AM -0700, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 02:38:27PM -0400, Benjamin Tissoires wrote: On Apr 23 2015 or thereabouts, Dmitry Torokhov wrote: On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: Creation, replacement and

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-07 Thread Jiri Kosina
On Mon, 6 Apr 2015, Dmitry Torokhov wrote: > > With > > https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-4.1/wacom=9a1c001298fd567c0f0776ab54ab9965eeb9019f > > in Jiri's tree, scheduled for 4.1, this patch should not break any existing > > driver. I'd like us to stage it

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-07 Thread Jiri Kosina
On Mon, 6 Apr 2015, Dmitry Torokhov wrote: With https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-4.1/wacomid=9a1c001298fd567c0f0776ab54ab9965eeb9019f in Jiri's tree, scheduled for 4.1, this patch should not break any existing driver. I'd like us to stage it

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-06 Thread Dmitry Torokhov
On Mon, Mar 30, 2015 at 02:54:15PM -0400, Benjamin Tissoires wrote: > The case occurred recently with a touchscreen using twice a slot during a > single EV_SYN event: > > E: 0.288415 # SYN_REPORT (0) -- > E: 0.296207 0003 002f # EV_ABS /

Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-04-06 Thread Dmitry Torokhov
On Mon, Mar 30, 2015 at 02:54:15PM -0400, Benjamin Tissoires wrote: The case occurred recently with a touchscreen using twice a slot during a single EV_SYN event: E: 0.288415 # SYN_REPORT (0) -- E: 0.296207 0003 002f # EV_ABS / ABS_MT_SLOT

[PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-03-30 Thread Benjamin Tissoires
The case occurred recently with a touchscreen using twice a slot during a single EV_SYN event: E: 0.288415 # SYN_REPORT (0) -- E: 0.296207 0003 002f # EV_ABS / ABS_MT_SLOT 0 E: 0.296207 0003 0039 -001 # EV_ABS / ABS_MT_TRACKING_ID

[PATCH v2] Input - mt: Fix input_mt_get_slot_by_key

2015-03-30 Thread Benjamin Tissoires
The case occurred recently with a touchscreen using twice a slot during a single EV_SYN event: E: 0.288415 # SYN_REPORT (0) -- E: 0.296207 0003 002f # EV_ABS / ABS_MT_SLOT 0 E: 0.296207 0003 0039 -001 # EV_ABS / ABS_MT_TRACKING_ID