Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2019-02-19 Thread Eric Biggers
On Thu, Feb 07, 2019 at 03:35:29PM -0800, Eric Biggers wrote: > On Thu, Jan 10, 2019 at 12:27:46PM -0800, Eric Biggers wrote: > > On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > > > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > > > From: Eric Biggers > > > > >

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2019-02-07 Thread Eric Biggers
On Thu, Jan 10, 2019 at 12:27:46PM -0800, Eric Biggers wrote: > On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2019-01-10 Thread Eric Biggers
On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > > called from construct_alloc_key() during sys_request_key(),

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-12-06 Thread Eric Biggers
On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > > called from construct_alloc_key() during sys_request_key(),

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-12-06 Thread Eric Biggers
On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > > called from construct_alloc_key() during sys_request_key(),

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-11-28 Thread Eric Biggers
On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > From: Eric Biggers > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > called from construct_alloc_key() during sys_request_key(), because the > length of the key description was never calculated. > > The

Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-11-28 Thread Eric Biggers
On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > From: Eric Biggers > > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > called from construct_alloc_key() during sys_request_key(), because the > length of the key description was never calculated. > > The

[PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-11-02 Thread Eric Biggers
From: Eric Biggers syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() called from construct_alloc_key() during sys_request_key(), because the length of the key description was never calculated. The problem is that we rely on ->desc_len being initialized by

[PATCH v2] KEYS: always initialize keyring_index_key::desc_len

2018-11-02 Thread Eric Biggers
From: Eric Biggers syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() called from construct_alloc_key() during sys_request_key(), because the length of the key description was never calculated. The problem is that we rely on ->desc_len being initialized by