Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-05-08 Thread Paul Bolle
Matthew, Paul Bolle schreef op ma 24-03-2014 om 16:36 [+0100]: > On Mon, 2014-03-24 at 09:31 -0400, Matthew Wilcox wrote: > > I should try things myself before opening my big mouth. Weird. Using > > gcc-4.8, I see the same thing. Guess I should just apply the patch, > > though it feels wrong to

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-24 Thread Paul Bolle
On Mon, 2014-03-24 at 16:49 +0100, Geert Uytterhoeven wrote: > On Mon, Mar 24, 2014 at 4:36 PM, Paul Bolle wrote: > > And as this is now unlikely to be in time for v3.14, we might decide to > > dig deeper. It won't be the first time that a rather small change (say, > > converting a variable from s

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-24 Thread Geert Uytterhoeven
Hi Paul, On Mon, Mar 24, 2014 at 4:36 PM, Paul Bolle wrote: > And as this is now unlikely to be in time for v3.14, we might decide to > dig deeper. It won't be the first time that a rather small change (say, > converting a variable from signed to unsigned) turns out be enough to > make GCC unders

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-24 Thread Paul Bolle
On Mon, 2014-03-24 at 09:31 -0400, Matthew Wilcox wrote: > I should try things myself before opening my big mouth. Weird. Using > gcc-4.8, I see the same thing. Guess I should just apply the patch, > though it feels wrong to be initialising an entire struct just to silence > a bogus compiler war

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-24 Thread Matthew Wilcox
On Mon, Mar 24, 2014 at 09:11:04AM -0400, Matthew Wilcox wrote: > On Tue, Mar 04, 2014 at 10:36:07AM +0100, Paul Bolle wrote: > > Also note that it's actually not clear to me why these warnings only > > trigger on 32 bit. I guess there's some int/long conversion lurking > > somewhere. I haven't fou

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-24 Thread Matthew Wilcox
On Tue, Mar 04, 2014 at 10:36:07AM +0100, Paul Bolle wrote: > Also note that it's actually not clear to me why these warnings only > trigger on 32 bit. I guess there's some int/long conversion lurking > somewhere. I haven't found it. I bet you're using a different revision of the compiler on 32 a

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-06 Thread Paul Bolle
On Wed, 2014-03-05 at 08:09 -0700, Keith Busch wrote: > Looks good to me. Thanks. > This won't apply in linux-nvme yet and it may be a > little while before it does, so this might be considered to go upstream > through a different tree if you want this in sooner. These warnings popped up in v3.1

Re: [PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-05 Thread Keith Busch
Looks good to me. This won't apply in linux-nvme yet and it may be a little while before it does, so this might be considered to go upstream through a different tree if you want this in sooner. On Tue, 4 Mar 2014, Paul Bolle wrote: Building nvme-core.o on 32 bit x86 triggers a rather impressive

[PATCH v2] NVMe: silence GCC warning on 32 bit

2014-03-04 Thread Paul Bolle
Building nvme-core.o on 32 bit x86 triggers a rather impressive set of GCC warnings: In file included from drivers/block/nvme-core.c:20:0: drivers/block/nvme-core.c: In function 'nvme_submit_bio_queue': include/linux/bio.h:154:55: warning: 'bvprv.bv_offset' may be used uninitialized in