Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Marc, Hi Marc, On 6/29/20 10:22 PM, Marc Zyngier wrote: > On 2020-06-29 12:29, Chanwoo Choi wrote: >> Hi Enric and Mark, >> >> On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote: >>> Hi Chanwoo and Marc, >>> >>> On 29/6/20 13:09, Chanwoo Choi wrote: Hi Enric, Could you check this

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Chanwoo, On 29/6/20 13:29, Chanwoo Choi wrote: > Hi Enric and Mark, > > On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote: >> Hi Chanwoo and Marc, >> >> On 29/6/20 13:09, Chanwoo Choi wrote: >>> Hi Enric, >>> >>> Could you check this issue? Your patch[1] causes this issue. >>> As Marc

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Enric and Mark, On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote: > Hi Chanwoo and Marc, > > On 29/6/20 13:09, Chanwoo Choi wrote: >> Hi Enric, >> >> Could you check this issue? Your patch[1] causes this issue. >> As Marc mentioned, although rk3399-dmc.c handled 'rockchip,pmu' >> as the

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Enric, Could you check this issue? Your patch[1] causes this issue. As Marc mentioned, although rk3399-dmc.c handled 'rockchip,pmu' as the mandatory property, your patch[1] didn't add the 'rockchip,pmu' property to the documentation. [1] 9173c5ceb035 ("PM / devfreq: rk3399_dmc: Pass ODT and

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Chanwoo and Marc, On 29/6/20 13:09, Chanwoo Choi wrote: > Hi Enric, > > Could you check this issue? Your patch[1] causes this issue. > As Marc mentioned, although rk3399-dmc.c handled 'rockchip,pmu' > as the mandatory property, your patch[1] didn't add the 'rockchip,pmu' > property to the

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Enric, On 6/29/20 8:26 PM, Enric Balletbo i Serra wrote: > Hi Chanwoo, > > On 29/6/20 13:29, Chanwoo Choi wrote: >> Hi Enric and Mark, >> >> On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote: >>> Hi Chanwoo and Marc, >>> >>> On 29/6/20 13:09, Chanwoo Choi wrote: Hi Enric, Could

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Chanwoo, On Mon, 29 Jun 2020 03:43:37 +0100, Chanwoo Choi wrote: > > Hi Marc, > > On 6/23/20 12:28 AM, Marc Zyngier wrote: [...] > It looks good to me. But, I think that it is not necessary > fully kernel panic log about NULL pointer. It is enoughspsp > just mentioning the NULL pointer

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

On 2020-06-29 12:29, Chanwoo Choi wrote: Hi Enric and Mark, On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote: Hi Chanwoo and Marc, On 29/6/20 13:09, Chanwoo Choi wrote: Hi Enric, Could you check this issue? Your patch[1] causes this issue. As Marc mentioned, although rk3399-dmc.c handled

Re: [PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Hi Marc, On 6/23/20 12:28 AM, Marc Zyngier wrote: > Booting a recent kernel on a rk3399-based system (nanopc-t4), > equipped with a recent u-boot and ATF results in the following: > > [5.607431] Unable to handle kernel NULL pointer dereference at virtual > address 01e4 > [

[PATCH v2] PM / devfreq: rk3399_dmc: Fix kernel oops when rockchip,pmu is absent

Booting a recent kernel on a rk3399-based system (nanopc-t4), equipped with a recent u-boot and ATF results in the following: [5.607431] Unable to handle kernel NULL pointer dereference at virtual address 01e4 [5.608219] Mem abort info: [5.608469] ESR = 0x9604 [