Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-15 Thread Johan Hovold
On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote: > Greybus GPIO seems to reimplement the already existing generic > gpiolib irqchip. Also use gpiochip_get_data(). Also use > devm_gpiochip_add_data(). > > Cc: Viresh Kumar > Cc: Axel Haslam

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-15 Thread Johan Hovold
On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote: > Greybus GPIO seems to reimplement the already existing generic > gpiolib irqchip. Also use gpiochip_get_data(). Also use > devm_gpiochip_add_data(). > > Cc: Viresh Kumar > Cc: Axel Haslam > Cc: Johan Hovold > Cc: Sandeep Patil >

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-11 Thread Viresh Kumar
I was looking to exactly do thanks, thanks for doing it before us :) On 10-10-16, 10:39, Linus Walleij wrote: > static int gb_gpio_probe(struct gbphy_device *gbphy_dev, >const struct gbphy_device_id *id) > { > @@ -690,7 +556,6 @@ static int gb_gpio_probe(struct

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-11 Thread Viresh Kumar
I was looking to exactly do thanks, thanks for doing it before us :) On 10-10-16, 10:39, Linus Walleij wrote: > static int gb_gpio_probe(struct gbphy_device *gbphy_dev, >const struct gbphy_device_id *id) > { > @@ -690,7 +556,6 @@ static int gb_gpio_probe(struct

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Rui Miguel Silva
Hi Linus, On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote: Greybus GPIO seems to reimplement the already existing generic gpiolib irqchip. Also use gpiochip_get_data(). Also use devm_gpiochip_add_data(). Cc: Viresh Kumar Cc: Axel Haslam

Re: [PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Rui Miguel Silva
Hi Linus, On Mon, Oct 10, 2016 at 10:39:32AM +0200, Linus Walleij wrote: Greybus GPIO seems to reimplement the already existing generic gpiolib irqchip. Also use gpiochip_get_data(). Also use devm_gpiochip_add_data(). Cc: Viresh Kumar Cc: Axel Haslam Cc: Johan Hovold Cc: Sandeep Patil Cc:

[PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Linus Walleij
Greybus GPIO seems to reimplement the already existing generic gpiolib irqchip. Also use gpiochip_get_data(). Also use devm_gpiochip_add_data(). Cc: Viresh Kumar Cc: Axel Haslam Cc: Johan Hovold Cc: Sandeep Patil

[PATCH v2] RFC: staging: greybus: shape up greybus GPIO

2016-10-10 Thread Linus Walleij
Greybus GPIO seems to reimplement the already existing generic gpiolib irqchip. Also use gpiochip_get_data(). Also use devm_gpiochip_add_data(). Cc: Viresh Kumar Cc: Axel Haslam Cc: Johan Hovold Cc: Sandeep Patil Cc: Rui Miguel Silva Cc: Greg Kroah-Hartman Signed-off-by: Linus Walleij ---