Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Fabio Falzoi
On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote: > > Seems I wasn't clear enough, you could use my ack if you put > struct flexfb_lcd_controller inside the driver and not in > fbtft.h > > > Noralf. > > Sorry Noralf, I misunderstood your review. I will modify the patch and send

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Noralf Trønnes
Den 02.08.2015 16:57, skrev Fabio Falzoi: Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD

[PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Fabio Falzoi
Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip controller simply defining a new

[PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Fabio Falzoi
Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD chip controller simply defining a new

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Noralf Trønnes
Den 02.08.2015 16:57, skrev Fabio Falzoi: Use a struct flexfb_lcd_controller to holds chip properties, instead of relying on a long 'if - else if' chain. This allows to: - use a simple linear search to verify if a certain LCD controller model is supported or not. - add support for a new LCD

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

2015-08-02 Thread Fabio Falzoi
On Sun, Aug 02, 2015 at 07:54:48PM +0200, Noralf Trønnes wrote: Seems I wasn't clear enough, you could use my ack if you put struct flexfb_lcd_controller inside the driver and not in fbtft.h Noralf. Sorry Noralf, I misunderstood your review. I will modify the patch and send an