Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-16 Thread gengdongjiu
Hello Tyler, I have already updated a new version patch to adds this usage to cper_estatus_check(), please re-test. Hello Boris, The original macro of apei_estatus_for_each_section has two issues: one is the iteration loop termination condition; another is the iteration steps. please review

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Baicar, Tyler
On 8/15/2017 3:34 PM, gengdongjiu wrote: Hi Tyler , Hello Boris, His patch fixes the define for apei_estatus_for_each_section which in turn should fix ghes_do_proc(). So my patch should no longer be needed. I'm going to test this out just to verify if fixes the issue I found. I have verified

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Hi Tyler , > Hello Boris, > > His patch fixes the define for apei_estatus_for_each_section which in turn > should fix ghes_do_proc(). So my patch should no longer be needed. I'm going > to test this out just to verify if fixes the issue I found. I have verified the issue about the iteration for t

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Borislav Petkov
On Tue, Aug 15, 2017 at 12:31:14PM -0600, Baicar, Tyler wrote: > His patch fixes the define for apei_estatus_for_each_section which in turn > should fix ghes_do_proc(). So my patch should no longer be needed. I see. We're keeping the macro, of course. > I'm going to test this out just to verify i

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Baicar, Tyler
On 8/15/2017 10:55 AM, Borislav Petkov wrote: On Wed, Aug 16, 2017 at 12:42:43AM +0800, gengdongjiu wrote: I ever discuss it with Tyler about it, as shown below link, thanks https://lkml.org/lkml/2017/8/14/355 Tyler's patch fixes ghes_do_proc() - yours cper_estatus_print(). How is that merged?

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Borislav Petkov
On Wed, Aug 16, 2017 at 12:42:43AM +0800, gengdongjiu wrote: > I ever discuss it with Tyler about it, as shown below link, thanks > > https://lkml.org/lkml/2017/8/14/355 Tyler's patch fixes ghes_do_proc() - yours cper_estatus_print(). How is that merged? -- Regards/Gruss, Boris. SUSE Linux

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Borislav, 2017-08-16 0:32 GMT+08:00, Borislav Petkov : > On Wed, Aug 16, 2017 at 12:30:55AM +0800, gengdongjiu wrote: >> I think this patch has merged them to one. > > Look at both patches again. I ever discuss it with Tyler about it, as shown below link, thanks https://lkml.org/lkml/2017/8/14/3

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Borislav Petkov
On Wed, Aug 16, 2017 at 12:30:55AM +0800, gengdongjiu wrote: > I think this patch has merged them to one. Look at both patches again. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Hi Borislav, > > ... and uses that accessor. > > Tyler? > > I'd prefer if you guys merge your two patches, Tyler's from > https://marc.info/?l=linux-acpi&m=150179595323038&w=2 and this one into > a single one. I think this patch has merged them to one. > > How does that sound? > > -- > Regards/G

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Borislav Petkov
On Tue, Aug 15, 2017 at 10:16:20PM +0800, gengdongjiu wrote: > 2017-08-15 19:15 GMT+08:00, Dongjiu Geng : > > The revision 0x300 generic error data entry is different > > from the old version, but currently iterating through the > > GHES estatus blocks does not take into account this difference. >

Re: [PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread gengdongjiu
Loop more people to review the patch. 2017-08-15 19:15 GMT+08:00, Dongjiu Geng : > The revision 0x300 generic error data entry is different > from the old version, but currently iterating through the > GHES estatus blocks does not take into account this difference. > This will lead to failure to

[PATCH v2] acpi: apei: fix the wrongly iterate generic error status block

2017-08-15 Thread Dongjiu Geng
The revision 0x300 generic error data entry is different from the old version, but currently iterating through the GHES estatus blocks does not take into account this difference. This will lead to failure to get the right data entry if GHES has revision 0x300 error data entry. Update the GHES esta