Re: [PATCH v2] arm64/hisilicon: fix SDcard detection

2019-02-02 Thread Vincent Guittot
Hi Wei, On Fri, 1 Feb 2019 at 18:00, Wei Xu wrote: > > Hi Vincent, > > On 1/14/2019 8:24 AM, Vincent Guittot wrote: > > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > > Instead of adding cd-inverted, we should better set correctly cd-gpios > > to use GPIO_ACTIVE_LOW. >

Re: [PATCH v2] arm64/hisilicon: fix SDcard detection

2019-02-01 Thread Wei Xu
Hi Vincent, On 1/14/2019 8:24 AM, Vincent Guittot wrote: > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > Instead of adding cd-inverted, we should better set correctly cd-gpios > to use GPIO_ACTIVE_LOW. > > Signed-off-by: Vincent Guittot Updated the subject as Leo sug

Re: [PATCH v2] arm64/hisilicon: fix SDcard detection

2019-01-14 Thread Leo Yan
Hi Vincent, On Mon, Jan 14, 2019 at 09:24:34AM +0100, Vincent Guittot wrote: > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > Instead of adding cd-inverted, we should better set correctly cd-gpios > to use GPIO_ACTIVE_LOW. Just remind, usually ARM maintainer has require

Re: [PATCH v2] arm64/hisilicon: fix SDcard detection

2019-01-14 Thread Linus Walleij
On Mon, Jan 14, 2019 at 9:24 AM Vincent Guittot wrote: > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > Instead of adding cd-inverted, we should better set correctly cd-gpios > to use GPIO_ACTIVE_LOW. > > Signed-off-by: Vincent Guittot Reviewed-by: Linus Walleij You

[PATCH v2] arm64/hisilicon: fix SDcard detection

2019-01-14 Thread Vincent Guittot
The SDcard detection of hikey960 is active low so cd-inverted is wrong. Instead of adding cd-inverted, we should better set correctly cd-gpios to use GPIO_ACTIVE_LOW. Signed-off-by: Vincent Guittot --- SD card detection was not working on v5.0-rc1 but patch https://marc.info/?l=linux-mmc&m=15463