Re: [PATCH v2] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS

2019-06-12 Thread Will Deacon
On Wed, Jun 12, 2019 at 10:25:20AM +0100, Dave Martin wrote: > On Tue, Jun 11, 2019 at 10:19:32AM -0700, Nathan Chancellor wrote: > > v1 -> v2: > > > > * Improve commit message explanation, I wasn't entirely happy with the > > first one; let me know if there are any issues/questions. > > > > *

Re: [PATCH v2] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS

2019-06-12 Thread Dave Martin
On Tue, Jun 11, 2019 at 10:19:32AM -0700, Nathan Chancellor wrote: > This is a GCC only option, which warns about ABI changes within GCC, so > unconditionally adding it breaks Clang with tons of: > > warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option] > > and link time

[PATCH v2] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS

2019-06-11 Thread Nathan Chancellor
This is a GCC only option, which warns about ABI changes within GCC, so unconditionally adding it breaks Clang with tons of: warning: unknown warning option '-Wno-psabi' [-Wunknown-warning-option] and link time failures: ld.lld: error: undefined symbol: __efistub___stack_chk_guard >>>