Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

2020-12-16 Thread Jens Axboe
On 11/30/20 3:19 AM, Daniel Wagner wrote: > It's guaranteed that no request is in flight when a hctx is going > offline. This warning is only triggered when the wq's CPU is hot > plugged and the blk-mq is not synced up yet. > > As this state is temporary and the request is still processed > correc

Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

2020-12-16 Thread Daniel Wagner
On Mon, Nov 30, 2020 at 05:17:48PM +, Christoph Hellwig wrote: > On Mon, Nov 30, 2020 at 11:19:21AM +0100, Daniel Wagner wrote: > > It's guaranteed that no request is in flight when a hctx is going > > offline. This warning is only triggered when the wq's CPU is hot > > plugged and the blk-mq i

Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

2020-11-30 Thread Ming Lei
On Mon, Nov 30, 2020 at 11:19:21AM +0100, Daniel Wagner wrote: > It's guaranteed that no request is in flight when a hctx is going > offline. This warning is only triggered when the wq's CPU is hot > plugged and the blk-mq is not synced up yet. > > As this state is temporary and the request is sti

Re: [PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

2020-11-30 Thread Christoph Hellwig
On Mon, Nov 30, 2020 at 11:19:21AM +0100, Daniel Wagner wrote: > It's guaranteed that no request is in flight when a hctx is going > offline. This warning is only triggered when the wq's CPU is hot > plugged and the blk-mq is not synced up yet. > > As this state is temporary and the request is sti

[PATCH v2] blk-mq: Remove 'running from the wrong CPU' warning

2020-11-30 Thread Daniel Wagner
It's guaranteed that no request is in flight when a hctx is going offline. This warning is only triggered when the wq's CPU is hot plugged and the blk-mq is not synced up yet. As this state is temporary and the request is still processed correctly, better remove the warning as this is the fast pat