Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-27 Thread Shuah Khan
Hi Joerg, On Thu, 2012-09-27 at 12:20 +0200, Joerg Roedel wrote: > Hi Shuah, > > the patch looks better then the older versions. It comes closer to a > merge, but I see one issue here: > > On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote: > > debug_dma_mapping_error(struct device *dev,

Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-27 Thread Joerg Roedel
Hi Shuah, the patch looks better then the older versions. It comes closer to a merge, but I see one issue here: On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote: > debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr): > Sets dma map error checked status for the dma map

Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-26 Thread Shuah Khan
On Wed, 2012-09-26 at 09:12 -0400, Konrad Rzeszutek Wilk wrote: > > > > Thanks for improving this patch. It is looking more and more ready for > the kernel. With that in mind, I've some comments below. Good. Thanks for the comments and good suggestions. Will work on v3. > > > > > > > --- a/lib

Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-26 Thread Konrad Rzeszutek Wilk
> Enhancements to dma-debug API are made to add new debugfs interfaces to > report total dma errors, dma errors that are not checked, and unmap errors > for the entire system. Please note that these are system wide counters for > all devices in the system. > > The following new dma-debug interface

[PATCH v2] dma-debug: New interfaces to debug dma mapping errors

2012-09-25 Thread Shuah Khan
A recent dma mapping error analysis effort showed that a large percentage of dma_map_single() and dma_map_page() returns are not checked for mapping errors. Reference: http://linuxdriverproject.org/mediawiki/index.php/DMA_Mapping_Error_Analysis Adding support for tracking dma mapping and unmappin