Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
On 22/04/16 14:56, Shardar Mohammed wrote: > Thanks for the review, please check my comments inline in [Shardar]. > >> On 22/04/16 13:44, Shardar Shariff Md wrote: >>> Initialize default channel slave_id(req_sel) to invalid id (i.e max >>> supported slave id + 1) to avoid overwriting of slave_id

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
On 22/04/16 14:56, Shardar Mohammed wrote: > Thanks for the review, please check my comments inline in [Shardar]. > >> On 22/04/16 13:44, Shardar Shariff Md wrote: >>> Initialize default channel slave_id(req_sel) to invalid id (i.e max >>> supported slave id + 1) to avoid overwriting of slave_id

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
> On 22/04/16 13:44, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client data if slave_id is not > > initialized through DT > > > >

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
> On 22/04/16 13:44, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client data if slave_id is not > > initialized through DT > > > >

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
> On Fri, Apr 22, 2016 at 06:14:53PM +0530, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client data if slave_id is not > > initialized through

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
> On Fri, Apr 22, 2016 at 06:14:53PM +0530, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client data if slave_id is not > > initialized through

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
Thanks for the review, please check my comments inline in [Shardar]. > On 22/04/16 13:44, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client

RE: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Mohammed
Thanks for the review, please check my comments inline in [Shardar]. > On 22/04/16 13:44, Shardar Shariff Md wrote: > > Initialize default channel slave_id(req_sel) to invalid id (i.e max > > supported slave id + 1) to avoid overwriting of slave_id during > > tegra_dma_slave_config() with client

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
On 22/04/16 13:44, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > > Signed-off-by: Shardar

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
On 22/04/16 13:44, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > > Signed-off-by: Shardar

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Thierry Reding
On Fri, Apr 22, 2016 at 06:14:53PM +0530, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > >

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Thierry Reding
On Fri, Apr 22, 2016 at 06:14:53PM +0530, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > >

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
Hi Shardar, On 22/04/16 13:44, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > >

Re: [PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Jon Hunter
Hi Shardar, On 22/04/16 13:44, Shardar Shariff Md wrote: > Initialize default channel slave_id(req_sel) to invalid id > (i.e max supported slave id + 1) to avoid overwriting of slave_id > during tegra_dma_slave_config() with client data if slave_id > is not initialized through DT > >

[PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Shariff Md
Initialize default channel slave_id(req_sel) to invalid id (i.e max supported slave id + 1) to avoid overwriting of slave_id during tegra_dma_slave_config() with client data if slave_id is not initialized through DT Signed-off-by: Shardar Shariff Md --- - Instead of

[PATCH v2] dmaengine: tegra-apb: proper default init of channel slave_id

2016-04-22 Thread Shardar Shariff Md
Initialize default channel slave_id(req_sel) to invalid id (i.e max supported slave id + 1) to avoid overwriting of slave_id during tegra_dma_slave_config() with client data if slave_id is not initialized through DT Signed-off-by: Shardar Shariff Md --- - Instead of initializing the slave id to