Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-09-25 Thread Rob Herring
On Wed, Aug 29, 2018 at 09:08:38AM +0200, Vincent Guittot wrote: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz *

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-09-25 Thread Rob Herring
On Wed, Aug 29, 2018 at 09:08:38AM +0200, Vincent Guittot wrote: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz *

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-09-03 Thread Viresh Kumar
On 29-08-18, 09:08, Vincent Guittot wrote: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; >

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-09-03 Thread Viresh Kumar
On 29-08-18, 09:08, Vincent Guittot wrote: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; >

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-30 Thread Punit Agrawal
Hi Vincent, Vincent Guittot writes: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; >

Re: [PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-30 Thread Punit Agrawal
Hi Vincent, Vincent Guittot writes: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is uW/MHz/V^2 > > In drivers/thermal/cpu_cooling.c, the code is : > > power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; >

[PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-29 Thread Vincent Guittot
The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas its usage in the code assumes that unit is uW/MHz/V^2 In drivers/thermal/cpu_cooling.c, the code is : power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; do_div(power, 10); which can be summarized as :

[PATCH v2] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

2018-08-29 Thread Vincent Guittot
The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas its usage in the code assumes that unit is uW/MHz/V^2 In drivers/thermal/cpu_cooling.c, the code is : power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; do_div(power, 10); which can be summarized as :