Re: [PATCH v2] ext4: make xattr inode reads faster

2017-08-05 Thread Theodore Ts'o
On Sun, Jul 16, 2017 at 11:20:12PM -0700, Tahsin Erdogan wrote: > ext4_xattr_inode_read() currently reads each block sequentially while > waiting for io operation to complete before moving on to the next > block. This prevents request merging in block layer. > > Add a ext4_bread_batch() function t

Re: [PATCH v2] ext4: make xattr inode reads faster

2017-07-16 Thread Tahsin Erdogan
> It surprises me that ext4/VFS doesn't already have a helper routine to do > this. > It looks like ext4_find_entry() is doing something similar for read-ahead of > directory blocks, so it may be worthwhile to consider moving that code over > to use ext4_bread_batch(), but it looks like it would n

[PATCH v2] ext4: make xattr inode reads faster

2017-07-16 Thread Tahsin Erdogan
ext4_xattr_inode_read() currently reads each block sequentially while waiting for io operation to complete before moving on to the next block. This prevents request merging in block layer. Add a ext4_bread_batch() function that starts reads for all blocks then optionally waits for them to complete