Re: [PATCH v2] fs: fix lost error code in dio_complete

2018-11-30 Thread Jens Axboe
On 11/30/18 3:46 AM, Christoph Hellwig wrote: > Al, Jens, > > can someone pick this up, please? > > On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote: >> On 11/8/18 7:58 PM, Maximilian Heyne wrote: >>> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the >>> generic_w

Re: [PATCH v2] fs: fix lost error code in dio_complete

2018-11-30 Thread Christoph Hellwig
Al, Jens, can someone pick this up, please? On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote: > On 11/8/18 7:58 PM, Maximilian Heyne wrote: >> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the >> generic_write_sync prototype") reworked callers of generic_write_syn

Re: [PATCH v2] fs: fix lost error code in dio_complete

2018-11-30 Thread Maximilian Heyne
On 11/8/18 7:58 PM, Maximilian Heyne wrote: commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error w

[PATCH v2] fs: fix lost error code in dio_complete

2018-11-08 Thread Maximilian Heyne
commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the generic_write_sync prototype") reworked callers of generic_write_sync(), and ended up dropping the error return for the directio path. Prior to that commit, in dio_complete(), an error would be bubbled up the stack, but after that c