Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-29 Thread Stephen Bates
> Do we still need #include ? For me, it compiles without it. Yes we do. Kbuild reported a failure when I tried omitting it (arm-multi_v7_defconfig). > Reviewed-by: Daniel Mentz danielme...@google.com Thanks for the review Andrew can you look at picking this up or do you want me to respin

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-29 Thread Stephen Bates
> Do we still need #include ? For me, it compiles without it. Yes we do. Kbuild reported a failure when I tried omitting it (arm-multi_v7_defconfig). > Reviewed-by: Daniel Mentz danielme...@google.com Thanks for the review Andrew can you look at picking this up or do you want me to respin

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-27 Thread Daniel Mentz
On Thu, Oct 26, 2017 at 9:04 AM, wrote: > --- a/include/linux/genalloc.h > +++ b/include/linux/genalloc.h > @@ -32,6 +32,7 @@ > > #include > #include > +#include Do we still need #include ? For me, it compiles without it. Reviewed-by: Daniel Mentz

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-27 Thread Daniel Mentz
On Thu, Oct 26, 2017 at 9:04 AM, wrote: > --- a/include/linux/genalloc.h > +++ b/include/linux/genalloc.h > @@ -32,6 +32,7 @@ > > #include > #include > +#include Do we still need #include ? For me, it compiles without it. Reviewed-by: Daniel Mentz

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread Mathieu Desnoyers
- On Oct 26, 2017, at 6:04 PM, Stephen Bates sba...@raithlin.com wrote: > From: Stephen Bates > > If the amount of resources allocated to a gen_pool exceeds 2^32 then > the avail atomic overflows and this causes problems when clients try > and borrow resources from the

Re: [PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread Mathieu Desnoyers
- On Oct 26, 2017, at 6:04 PM, Stephen Bates sba...@raithlin.com wrote: > From: Stephen Bates > > If the amount of resources allocated to a gen_pool exceeds 2^32 then > the avail atomic overflows and this causes problems when clients try > and borrow resources from the pool. This is only

[PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread sbates
From: Stephen Bates If the amount of resources allocated to a gen_pool exceeds 2^32 then the avail atomic overflows and this causes problems when clients try and borrow resources from the pool. This is only expected to be an issue on 64 bit systems. Add the header to pull

[PATCH v2] genalloc: Make the avail variable an atomic_long_t

2017-10-26 Thread sbates
From: Stephen Bates If the amount of resources allocated to a gen_pool exceeds 2^32 then the avail atomic overflows and this causes problems when clients try and borrow resources from the pool. This is only expected to be an issue on 64 bit systems. Add the header to pull in atomic_long*