Re: [PATCH v2] gpio: winbond: add driver

On 29.12.2017 17:09, William Breathitt Gray wrote: > On Fri, Dec 29, 2017 at 12:27:12PM +0200, Andy Shevchenko wrote: >> On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >>> On 28.12.2017 16:12, Andy Shevchenko wrote: On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote:

Re: [PATCH v2] gpio: winbond: add driver

On 29.12.2017 11:27, Andy Shevchenko wrote: > On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >> On 28.12.2017 16:12, Andy Shevchenko wrote: >>> On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > +You will need to provide a module parameter "gpios", or

Re: [PATCH v2] gpio: winbond: add driver

On 29.12.2017 17:09, William Breathitt Gray wrote: > On Fri, Dec 29, 2017 at 12:27:12PM +0200, Andy Shevchenko wrote: >> On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >>> On 28.12.2017 16:12, Andy Shevchenko wrote: On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote:

Re: [PATCH v2] gpio: winbond: add driver

On 29.12.2017 11:27, Andy Shevchenko wrote: > On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >> On 28.12.2017 16:12, Andy Shevchenko wrote: >>> On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > +You will need to provide a module parameter "gpios", or

Re: [PATCH v2] gpio: winbond: add driver

On Fri, Dec 29, 2017 at 12:27:12PM +0200, Andy Shevchenko wrote: >On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >> On 28.12.2017 16:12, Andy Shevchenko wrote: >> > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: >> > > > >> > > + You will need to provide a

Re: [PATCH v2] gpio: winbond: add driver

On Fri, Dec 29, 2017 at 12:27:12PM +0200, Andy Shevchenko wrote: >On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: >> On 28.12.2017 16:12, Andy Shevchenko wrote: >> > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: >> > > > >> > > + You will need to provide a

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: > On 28.12.2017 16:12, Andy Shevchenko wrote: > > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > > > > > > + You will need to provide a module parameter "gpios", or > > > a > > > + boot-time parameter

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-29 at 00:44 +0100, Maciej S. Szmigiero wrote: > On 28.12.2017 16:12, Andy Shevchenko wrote: > > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > > > > > > + You will need to provide a module parameter "gpios", or > > > a > > > + boot-time parameter

Re: [PATCH v2] gpio: winbond: add driver

On 28.12.2017 16:12, Andy Shevchenko wrote: > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for other Winbond

Re: [PATCH v2] gpio: winbond: add driver

On 28.12.2017 16:12, Andy Shevchenko wrote: > On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for other Winbond

Re: [PATCH v2] gpio: winbond: add driver

On 28.12.2017 05:58, William Breathitt Gray wrote: > On Wed, Dec 27, 2017 at 07:42:21PM +0100, Maciej S. Szmigiero wrote: >> On 27.12.2017 01:24, William Breathitt Gray wrote: >>> On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >> (..) All the existing ISA bus drivers

Re: [PATCH v2] gpio: winbond: add driver

On 28.12.2017 05:58, William Breathitt Gray wrote: > On Wed, Dec 27, 2017 at 07:42:21PM +0100, Maciej S. Szmigiero wrote: >> On 27.12.2017 01:24, William Breathitt Gray wrote: >>> On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >> (..) All the existing ISA bus drivers

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. Linus, since you asked me to review this, I can conclude that it is a bit far from readiness. Couple of more iterations needed. Please, also answer to a comment in review in

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. Linus, since you asked me to review this, I can conclude that it is a bit far from readiness. Couple of more iterations needed. Please, also answer to a comment in review in

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. > > Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is > supported but in the future a support for other Winbond models, too, > can > be added to the driver. > >

Re: [PATCH v2] gpio: winbond: add driver

On Fri, 2017-12-22 at 19:58 +0100, Maciej S. Szmigiero wrote: > This commit adds GPIO driver for Winbond Super I/Os. > > Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is > supported but in the future a support for other Winbond models, too, > can > be added to the driver. > >

Re: [PATCH v2] gpio: winbond: add driver

On Thu, Dec 28, 2017 at 5:33 AM, William Breathitt Gray wrote: > Given that CONFIG_PC104 now fulfills the original purpose of adding > ISA_BUS_API to the depends on line for the PC/104 device drivers, and > that ISA_BUS_API can be selected as necessary with no danger to

Re: [PATCH v2] gpio: winbond: add driver

On Thu, Dec 28, 2017 at 5:33 AM, William Breathitt Gray wrote: > Given that CONFIG_PC104 now fulfills the original purpose of adding > ISA_BUS_API to the depends on line for the PC/104 device drivers, and > that ISA_BUS_API can be selected as necessary with no danger to the > integrity of the

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 07:42:21PM +0100, Maciej S. Szmigiero wrote: >On 27.12.2017 01:24, William Breathitt Gray wrote: >> On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >(..) >>> All the existing ISA bus drivers seem to depend on CONFIG_ISA_BUS_API >>> instead of selecting

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 07:42:21PM +0100, Maciej S. Szmigiero wrote: >On 27.12.2017 01:24, William Breathitt Gray wrote: >> On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >(..) >>> All the existing ISA bus drivers seem to depend on CONFIG_ISA_BUS_API >>> instead of selecting

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 12:16:53PM +0100, Linus Walleij wrote: >On Wed, Dec 27, 2017 at 1:24 AM, William Breathitt Gray > wrote: > >> The issue seems to relate to the select GPIOLIB line for the STX104 >> Kconfig option (which has a ISA_BUS_API dependency). Switching

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 12:16:53PM +0100, Linus Walleij wrote: >On Wed, Dec 27, 2017 at 1:24 AM, William Breathitt Gray > wrote: > >> The issue seems to relate to the select GPIOLIB line for the STX104 >> Kconfig option (which has a ISA_BUS_API dependency). Switching GPIOLIB >> to be a dependency,

Re: [PATCH v2] gpio: winbond: add driver

On 27.12.2017 01:24, William Breathitt Gray wrote: > On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: (..) >> All the existing ISA bus drivers seem to depend on CONFIG_ISA_BUS_API >> instead of selecting it but IMHO this is wrong because: >> 1) This Kconfig option doesn't

Re: [PATCH v2] gpio: winbond: add driver

On 27.12.2017 01:24, William Breathitt Gray wrote: > On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: (..) >> All the existing ISA bus drivers seem to depend on CONFIG_ISA_BUS_API >> instead of selecting it but IMHO this is wrong because: >> 1) This Kconfig option doesn't

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 1:24 AM, William Breathitt Gray wrote: > Here are the error messages printed on my system when I add a select > ISA_BUS_API line to the GPIO_WINBOND Kconfig option in the version 2 of > your patch: > > drivers/gpio/Kconfig:13:error: recursive

Re: [PATCH v2] gpio: winbond: add driver

On Wed, Dec 27, 2017 at 1:24 AM, William Breathitt Gray wrote: > Here are the error messages printed on my system when I add a select > ISA_BUS_API line to the GPIO_WINBOND Kconfig option in the version 2 of > your patch: > > drivers/gpio/Kconfig:13:error: recursive dependency detected! > For a

Re: [PATCH v2] gpio: winbond: add driver

On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >On 24.12.2017 23:42, William Breathitt Gray wrote: >(..) >> By the way, don't hesitate to ask for more information on the ISA >> subsystem -- a lot of maintainers are unaware that it even exists since >> so few devices nowadays

Re: [PATCH v2] gpio: winbond: add driver

On Mon, Dec 25, 2017 at 03:48:16PM +0100, Maciej S. Szmigiero wrote: >On 24.12.2017 23:42, William Breathitt Gray wrote: >(..) >> By the way, don't hesitate to ask for more information on the ISA >> subsystem -- a lot of maintainers are unaware that it even exists since >> so few devices nowadays

Re: [PATCH v2] gpio: winbond: add driver

On 24.12.2017 23:42, William Breathitt Gray wrote: (..) > By the way, don't hesitate to ask for more information on the ISA > subsystem -- a lot of maintainers are unaware that it even exists since > so few devices nowadays use ISA-style communication -- but I'm always > happy to help. :) It

Re: [PATCH v2] gpio: winbond: add driver

On 24.12.2017 23:42, William Breathitt Gray wrote: (..) > By the way, don't hesitate to ask for more information on the ISA > subsystem -- a lot of maintainers are unaware that it even exists since > so few devices nowadays use ISA-style communication -- but I'm always > happy to help. :) It

Re: [PATCH v2] gpio: winbond: add driver

On 24.12.2017 23:42, William Breathitt Gray wrote: > On Fri, Dec 22, 2017 at 07:58:49PM +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for

Re: [PATCH v2] gpio: winbond: add driver

On 24.12.2017 23:42, William Breathitt Gray wrote: > On Fri, Dec 22, 2017 at 07:58:49PM +0100, Maciej S. Szmigiero wrote: >> This commit adds GPIO driver for Winbond Super I/Os. >> >> Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >> supported but in the future a support for

Re: [PATCH v2] gpio: winbond: add driver

On Fri, Dec 22, 2017 at 07:58:49PM +0100, Maciej S. Szmigiero wrote: >This commit adds GPIO driver for Winbond Super I/Os. > >Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >supported but in the future a support for other Winbond models, too, can >be added to the driver. > >A

Re: [PATCH v2] gpio: winbond: add driver

On Fri, Dec 22, 2017 at 07:58:49PM +0100, Maciej S. Szmigiero wrote: >This commit adds GPIO driver for Winbond Super I/Os. > >Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is >supported but in the future a support for other Winbond models, too, can >be added to the driver. > >A

[PATCH v2] gpio: winbond: add driver

This commit adds GPIO driver for Winbond Super I/Os. Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is supported but in the future a support for other Winbond models, too, can be added to the driver. A module parameter "gpios" sets a bitmask of GPIO ports to enable (bit 0 is

[PATCH v2] gpio: winbond: add driver

This commit adds GPIO driver for Winbond Super I/Os. Currently, only W83627UHG model (also known as Nuvoton NCT6627UD) is supported but in the future a support for other Winbond models, too, can be added to the driver. A module parameter "gpios" sets a bitmask of GPIO ports to enable (bit 0 is