Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread matthieu castet
Le Tue, 25 Sep 2012 15:44:57 +, Arnd Bergmann a écrit : > > It's not possible to build a kernel that runs on ARMv5 (or below) and > also on ARMv6 (or above), so the effect would be exactly the same. > While we are putting a lot of effort into making all sorts of ARMv6 > and ARMv7 based

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2012, Matthieu CASTET wrote: > > static inline char __dcc_getchar(void) > > { > > char __c; > > > > if (__LINUX_ARM_ARCH >= 6) > > asm volatile("mrc p14, 0, %0, c0, c5, 0 @ read comms data reg" > > : "=r" (__c)); > >

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Matthieu CASTET
Stephen Boyd a écrit : > On 8/31/2012 4:47 AM, Matthieu CASTET wrote: >> Signed-off-by: Matthieu Castet > > Please consider adding some sort of commit text. Does this add some new > feature I may want on some downstream distro kernel? > ok > > It's unfortunate that the main logic is

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Matthieu CASTET
Arnd Bergmann a écrit : > On Friday 31 August 2012, Stephen Boyd wrote: >>> +static int hvc_dcc_put_chars_v6(uint32_t vt, const char *buf, int count) >>> +{ >>> + int i; >>> + >>> + for (i = 0; i < count; i++) { >>> + while (__dcc_getstatus_v6() & DCC_STATUS_TX_V6) >>> +

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Matthieu CASTET
Arnd Bergmann a écrit : On Friday 31 August 2012, Stephen Boyd wrote: +static int hvc_dcc_put_chars_v6(uint32_t vt, const char *buf, int count) +{ + int i; + + for (i = 0; i count; i++) { + while (__dcc_getstatus_v6() DCC_STATUS_TX_V6) +

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Matthieu CASTET
Stephen Boyd a écrit : On 8/31/2012 4:47 AM, Matthieu CASTET wrote: Signed-off-by: Matthieu Castet matthieu.cas...@parrot.com Please consider adding some sort of commit text. Does this add some new feature I may want on some downstream distro kernel? ok It's unfortunate that the main

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread Arnd Bergmann
On Tuesday 25 September 2012, Matthieu CASTET wrote: static inline char __dcc_getchar(void) { char __c; if (__LINUX_ARM_ARCH = 6) asm volatile(mrc p14, 0, %0, c0, c5, 0 @ read comms data reg : =r (__c)); else

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-25 Thread matthieu castet
Le Tue, 25 Sep 2012 15:44:57 +, Arnd Bergmann a...@arndb.de a écrit : It's not possible to build a kernel that runs on ARMv5 (or below) and also on ARMv6 (or above), so the effect would be exactly the same. While we are putting a lot of effort into making all sorts of ARMv6 and ARMv7

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-03 Thread Arnd Bergmann
On Friday 31 August 2012, Stephen Boyd wrote: > > +static int hvc_dcc_put_chars_v6(uint32_t vt, const char *buf, int count) > > +{ > > + int i; > > + > > + for (i = 0; i < count; i++) { > > + while (__dcc_getstatus_v6() & DCC_STATUS_TX_V6) > > + cpu_relax();

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-09-03 Thread Arnd Bergmann
On Friday 31 August 2012, Stephen Boyd wrote: +static int hvc_dcc_put_chars_v6(uint32_t vt, const char *buf, int count) +{ + int i; + + for (i = 0; i count; i++) { + while (__dcc_getstatus_v6() DCC_STATUS_TX_V6) + cpu_relax(); + +

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-08-31 Thread Stephen Boyd
On 8/31/2012 4:47 AM, Matthieu CASTET wrote: > Signed-off-by: Matthieu Castet Please consider adding some sort of commit text. Does this add some new feature I may want on some downstream distro kernel? > @@ -51,7 +51,7 @@ static inline char __dcc_getchar(void) > return __c; > } > >

[PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-08-31 Thread Matthieu CASTET
Signed-off-by: Matthieu Castet --- drivers/tty/hvc/hvc_dcc.c | 83 + 1 file changed, 76 insertions(+), 7 deletions(-) diff --git a/drivers/tty/hvc/hvc_dcc.c b/drivers/tty/hvc/hvc_dcc.c index 44fbeba..5f8827f 100644 --- a/drivers/tty/hvc/hvc_dcc.c

[PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-08-31 Thread Matthieu CASTET
Signed-off-by: Matthieu Castet matthieu.cas...@parrot.com --- drivers/tty/hvc/hvc_dcc.c | 83 + 1 file changed, 76 insertions(+), 7 deletions(-) diff --git a/drivers/tty/hvc/hvc_dcc.c b/drivers/tty/hvc/hvc_dcc.c index 44fbeba..5f8827f 100644 ---

Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core

2012-08-31 Thread Stephen Boyd
On 8/31/2012 4:47 AM, Matthieu CASTET wrote: Signed-off-by: Matthieu Castet matthieu.cas...@parrot.com Please consider adding some sort of commit text. Does this add some new feature I may want on some downstream distro kernel? @@ -51,7 +51,7 @@ static inline char __dcc_getchar(void)