On Fri, Oct 3, 2014 at 12:36 PM, Wolfram Sang wrote:
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 2ac87fa..8983474 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -77,6 +77,17 @@ config I2C_AMD8111
>> This driver can
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 2ac87fa..8983474 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -77,6 +77,17 @@ config I2C_AMD8111
> This driver can also be built as a module. If so, the module
>
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 2ac87fa..8983474 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -77,6 +77,17 @@ config I2C_AMD8111
This driver can also be built as a module. If so, the module
will be
On Fri, Oct 3, 2014 at 12:36 PM, Wolfram Sang w...@the-dreams.de wrote:
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 2ac87fa..8983474 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -77,6 +77,17 @@ config I2C_AMD8111
This
> >>Its looks good if we move the entire ISR above probe/remove
> >>functionalities...
> >>
> >Not sure what you mean here... The ISR _is_ above probe/remove.
>
> I mean ISR should immediately above probe functionality. So that we can see
> devm_request_irq(..,isr_name,..) ISR directly with isr
On 09/29/2014 04:43 PM, Anders Berg wrote:
On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram wrote:
On 09/29/2014 03:02 PM, Anders Berg wrote:
Add I2C bus driver for the controller found in the LSI Axxia family SoCs.
The
driver implements 10-bit addressing and SMBus transfer modes via emulation
On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram wrote:
> On 09/29/2014 03:02 PM, Anders Berg wrote:
>>
>> Add I2C bus driver for the controller found in the LSI Axxia family SoCs.
>> The
>> driver implements 10-bit addressing and SMBus transfer modes via emulation
>> (including SMBus block data
On 09/29/2014 03:43 PM, Wolfram Sang wrote:
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Error checking on *res*...?
We should *return* on platform_get_resource() failure..
+ base = devm_ioremap_resource(>dev, res);
Nope. devm_ioremap_resource does that.
Yes it will
> >+res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>
> Error checking on *res*...?
>
> We should *return* on platform_get_resource() failure..
>
> >+base = devm_ioremap_resource(>dev, res);
Nope. devm_ioremap_resource does that.
signature.asc
Description: Digital signature
On 09/29/2014 03:02 PM, Anders Berg wrote:
Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
driver implements 10-bit addressing and SMBus transfer modes via emulation
(including SMBus block data read).
Signed-off-by: Anders Berg
---
Changelog
v2:
- Document
Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
driver implements 10-bit addressing and SMBus transfer modes via emulation
(including SMBus block data read).
Signed-off-by: Anders Berg
---
Changelog
v2:
- Document the len <= 255 limitation
- return
Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
driver implements 10-bit addressing and SMBus transfer modes via emulation
(including SMBus block data read).
Signed-off-by: Anders Berg anders.b...@avagotech.com
---
Changelog
v2:
- Document the len = 255
On 09/29/2014 03:02 PM, Anders Berg wrote:
Add I2C bus driver for the controller found in the LSI Axxia family SoCs. The
driver implements 10-bit addressing and SMBus transfer modes via emulation
(including SMBus block data read).
Signed-off-by: Anders Berg anders.b...@avagotech.com
---
+res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Error checking on *res*...?
We should *return* on platform_get_resource() failure..
+base = devm_ioremap_resource(pdev-dev, res);
Nope. devm_ioremap_resource does that.
signature.asc
Description: Digital signature
On 09/29/2014 03:43 PM, Wolfram Sang wrote:
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Error checking on *res*...?
We should *return* on platform_get_resource() failure..
+ base = devm_ioremap_resource(pdev-dev, res);
Nope. devm_ioremap_resource does that.
Yes it
On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram varkabhad...@gmail.com wrote:
On 09/29/2014 03:02 PM, Anders Berg wrote:
Add I2C bus driver for the controller found in the LSI Axxia family SoCs.
The
driver implements 10-bit addressing and SMBus transfer modes via emulation
(including SMBus
On 09/29/2014 04:43 PM, Anders Berg wrote:
On Mon, Sep 29, 2014 at 12:07 PM, Varka Bhadram varkabhad...@gmail.com wrote:
On 09/29/2014 03:02 PM, Anders Berg wrote:
Add I2C bus driver for the controller found in the LSI Axxia family SoCs.
The
driver implements 10-bit addressing and SMBus
Its looks good if we move the entire ISR above probe/remove
functionalities...
Not sure what you mean here... The ISR _is_ above probe/remove.
I mean ISR should immediately above probe functionality. So that we can see
devm_request_irq(..,isr_name,..) ISR directly with isr name..
Not so
18 matches
Mail list logo
