Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-11 Thread Yang Yingliang
Hi, Marc On 2018/6/11 17:31, Marc Zyngier wrote: On 06/06/18 03:40, Yang Yingliang wrote: When the kernel booted with maxcpus=x, 'x' is smaller than actual cpu numbers, the TAs of offline cpus won't be set to its->collection. If LPI is bind to offline cpu, sync cmd will use zero TA, it leads

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-11 Thread Yang Yingliang
Hi, Marc On 2018/6/11 17:31, Marc Zyngier wrote: On 06/06/18 03:40, Yang Yingliang wrote: When the kernel booted with maxcpus=x, 'x' is smaller than actual cpu numbers, the TAs of offline cpus won't be set to its->collection. If LPI is bind to offline cpu, sync cmd will use zero TA, it leads

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-11 Thread Marc Zyngier
On 06/06/18 03:40, Yang Yingliang wrote: > When the kernel booted with maxcpus=x, 'x' is smaller > than actual cpu numbers, the TAs of offline cpus won't > be set to its->collection. > > If LPI is bind to offline cpu, sync cmd will use zero TA, > it leads to ITS queue timeout. Fix this by

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-11 Thread Marc Zyngier
On 06/06/18 03:40, Yang Yingliang wrote: > When the kernel booted with maxcpus=x, 'x' is smaller > than actual cpu numbers, the TAs of offline cpus won't > be set to its->collection. > > If LPI is bind to offline cpu, sync cmd will use zero TA, > it leads to ITS queue timeout. Fix this by

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-10 Thread Marc Zyngier
Hi Hanjun, On Thu, 07 Jun 2018 13:25:26 +0100, Hanjun Guo wrote: > > Hi Marc, > > On 2018/6/6 17:13, Marc Zyngier wrote: > [...] > > > > Wouldn't it be better to just return that the affinity setting request > > is impossible to satisfy? And more to the point, how comes we end-up > > in such

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-10 Thread Marc Zyngier
Hi Hanjun, On Thu, 07 Jun 2018 13:25:26 +0100, Hanjun Guo wrote: > > Hi Marc, > > On 2018/6/6 17:13, Marc Zyngier wrote: > [...] > > > > Wouldn't it be better to just return that the affinity setting request > > is impossible to satisfy? And more to the point, how comes we end-up > > in such

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-07 Thread Hanjun Guo
Hi Marc, On 2018/6/6 17:13, Marc Zyngier wrote: [...] > > Wouldn't it be better to just return that the affinity setting request > is impossible to satisfy? And more to the point, how comes we end-up > in such a case? The system is booted with a NUMA node has no memory attaching to it

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-07 Thread Hanjun Guo
Hi Marc, On 2018/6/6 17:13, Marc Zyngier wrote: [...] > > Wouldn't it be better to just return that the affinity setting request > is impossible to satisfy? And more to the point, how comes we end-up > in such a case? The system is booted with a NUMA node has no memory attaching to it

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-06 Thread Marc Zyngier
On Wed, 06 Jun 2018 03:40:24 +0100, Yang Yingliang wrote: [I'm travelling, so please do not expect any quick answer...] > > When the kernel booted with maxcpus=x, 'x' is smaller > than actual cpu numbers, the TAs of offline cpus won't TA? Target Address? Target Affinity? Timing Advance?

Re: [PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-06 Thread Marc Zyngier
On Wed, 06 Jun 2018 03:40:24 +0100, Yang Yingliang wrote: [I'm travelling, so please do not expect any quick answer...] > > When the kernel booted with maxcpus=x, 'x' is smaller > than actual cpu numbers, the TAs of offline cpus won't TA? Target Address? Target Affinity? Timing Advance?

[PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-05 Thread Yang Yingliang
When the kernel booted with maxcpus=x, 'x' is smaller than actual cpu numbers, the TAs of offline cpus won't be set to its->collection. If LPI is bind to offline cpu, sync cmd will use zero TA, it leads to ITS queue timeout. Fix this by choosing a online cpu, if there is no online cpu in

[PATCH v2] irqchip/gic-v3-its: fix ITS queue timeout

2018-06-05 Thread Yang Yingliang
When the kernel booted with maxcpus=x, 'x' is smaller than actual cpu numbers, the TAs of offline cpus won't be set to its->collection. If LPI is bind to offline cpu, sync cmd will use zero TA, it leads to ITS queue timeout. Fix this by choosing a online cpu, if there is no online cpu in