RE: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-13 Thread David Laight
From: Joe Perches > Sent: 13 August 2019 08:05 ... > The afs ones seem to be because the last comment in the block > is not the fallthrough, but a description of the next case; > > e.g.: from fs/afs/fsclient.c: > > /* extract the volume name */ > case 3: >

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-13 Thread Joe Perches
On Tue, 2019-08-13 at 00:04 -0700, Joe Perches wrote: > On Mon, 2019-08-12 at 23:33 -0700, Nathan Chancellor wrote: [] > > a disagreement between GCC and Clang on > > emitting a warning when falling through to a case statement that is > > either the last one and empty or simply breaks.. [] > > I

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-13 Thread Joe Perches
On Mon, 2019-08-12 at 23:33 -0700, Nathan Chancellor wrote: > On Mon, Aug 12, 2019 at 04:11:26PM -0700, Nick Desaulniers wrote: > > Correct, Nathan is currently implementing support for attribute > > fallthrough in Clang in: > > https://reviews.llvm.org/D64838 > > > > I asked him in person to

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-13 Thread Nathan Chancellor
On Mon, Aug 12, 2019 at 04:11:26PM -0700, Nick Desaulniers wrote: > Correct, Nathan is currently implementing support for attribute > fallthrough in Clang in: > https://reviews.llvm.org/D64838 > > I asked him in person to evaluate how many warnings we'd see in an > arm64 defconfig with his patch

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-12 Thread Joe Perches
On Mon, 2019-08-12 at 16:11 -0700, Nick Desaulniers wrote: > On Mon, Aug 12, 2019 at 3:40 PM Joe Perches wrote: > > On Mon, 2019-08-12 at 15:14 -0700, Nathan Huckleberry wrote: > > > Clang does not support the use of comments to label > > > intentional fallthrough. This patch replaces some uses >

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-12 Thread Nick Desaulniers
On Mon, Aug 12, 2019 at 3:40 PM Joe Perches wrote: > > On Mon, 2019-08-12 at 15:14 -0700, Nathan Huckleberry wrote: > > Clang does not support the use of comments to label > > intentional fallthrough. This patch replaces some uses > > of comments to attributesto cut down a significant number > >

Re: [PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-12 Thread Joe Perches
On Mon, 2019-08-12 at 15:14 -0700, Nathan Huckleberry wrote: > Clang does not support the use of comments to label > intentional fallthrough. This patch replaces some uses > of comments to attributesto cut down a significant number > of warnings on clang (from ~5 to ~200). Only comments > in

[PATCH v2] kbuild: Change fallthrough comments to attributes

2019-08-12 Thread Nathan Huckleberry
Clang does not support the use of comments to label intentional fallthrough. This patch replaces some uses of comments to attributesto cut down a significant number of warnings on clang (from ~5 to ~200). Only comments in commonly used header files have been replaced. Since there is still