Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Masahiro Yamada
On Fri, May 17, 2019 at 2:34 PM Stephen Rothwell wrote: > > Hi Masahiro, > > Thanks for this, looks good to me. Just a nit below. > > On Fri, 17 May 2019 13:27:53 +0900 Masahiro Yamada > wrote: > > > > > diff --git a/scripts/modules-check.sh b/scripts/modules-check.sh > > new file mode 100755

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Masahiro Yamada
On Fri, May 17, 2019 at 2:46 PM Lucas De Marchi wrote: > > On Thu, May 16, 2019 at 10:37 PM Greg KH wrote: > > > > On Fri, May 17, 2019 at 01:45:11PM +0900, Masahiro Yamada wrote: > > > On Fri, May 17, 2019 at 1:29 PM Masahiro Yamada > > > wrote: > > > > > > > > In the recent build test of

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Masahiro Yamada
On Fri, May 17, 2019 at 6:25 PM Alexander Kapshuk wrote: > > On Fri, May 17, 2019 at 11:58 AM Bernd Petrovitsch > wrote: > > > > On 17/05/2019 10:16, Alexander Kapshuk wrote: > > [...] > > > The 'xargs' '-r' flag is a GNU extension. > > > If POSIX compliance is important here, the use of 'cat',

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Bernd Petrovitsch
On 17/05/2019 11:25, Alexander Kapshuk wrote: > On Fri, May 17, 2019 at 11:58 AM Bernd Petrovitsch > wrote: >> >> On 17/05/2019 10:16, Alexander Kapshuk wrote: >> [...] >>> The 'xargs' '-r' flag is a GNU extension. >>> If POSIX compliance is important here, the use of 'cat', 'xargs' and >>>

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Bernd Petrovitsch
On 17/05/2019 10:16, Alexander Kapshuk wrote: [...] > The 'xargs' '-r' flag is a GNU extension. > If POSIX compliance is important here, the use of 'cat', 'xargs' and > 'basename' may be substituted with that of 'sed' to initialise > same_name_modules: > sed 's!.*/!!' modules.order modules.builtin

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Alexander Kapshuk
On Fri, May 17, 2019 at 11:58 AM Bernd Petrovitsch wrote: > > On 17/05/2019 10:16, Alexander Kapshuk wrote: > [...] > > The 'xargs' '-r' flag is a GNU extension. > > If POSIX compliance is important here, the use of 'cat', 'xargs' and > > 'basename' may be substituted with that of 'sed' to

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-17 Thread Alexander Kapshuk
On Fri, May 17, 2019 at 8:33 AM Masahiro Yamada wrote: > > In the recent build test of linux-next, Stephen saw a build error > caused by a broken .tmp_versions/*.mod file: > > https://lkml.org/lkml/2019/5/13/991 > > drivers/net/phy/asix.ko and drivers/net/usb/asix.ko have the same > basename,

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Lucas De Marchi
On Thu, May 16, 2019 at 10:37 PM Greg KH wrote: > > On Fri, May 17, 2019 at 01:45:11PM +0900, Masahiro Yamada wrote: > > On Fri, May 17, 2019 at 1:29 PM Masahiro Yamada > > wrote: > > > > > > In the recent build test of linux-next, Stephen saw a build error > > > caused by a broken

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Greg KH
On Fri, May 17, 2019 at 01:45:11PM +0900, Masahiro Yamada wrote: > On Fri, May 17, 2019 at 1:29 PM Masahiro Yamada > wrote: > > > > In the recent build test of linux-next, Stephen saw a build error > > caused by a broken .tmp_versions/*.mod file: > > > > https://lkml.org/lkml/2019/5/13/991 > >

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Stephen Rothwell
Hi Masahiro, Thanks for this, looks good to me. Just a nit below. On Fri, 17 May 2019 13:27:53 +0900 Masahiro Yamada wrote: > > diff --git a/scripts/modules-check.sh b/scripts/modules-check.sh > new file mode 100755 > index ..c875f6eab01e > --- /dev/null > +++

Re: [PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Masahiro Yamada
On Fri, May 17, 2019 at 1:29 PM Masahiro Yamada wrote: > > In the recent build test of linux-next, Stephen saw a build error > caused by a broken .tmp_versions/*.mod file: > > https://lkml.org/lkml/2019/5/13/991 > > drivers/net/phy/asix.ko and drivers/net/usb/asix.ko have the same > basename,

[PATCH v2] kbuild: check uniqueness of module names

2019-05-16 Thread Masahiro Yamada
In the recent build test of linux-next, Stephen saw a build error caused by a broken .tmp_versions/*.mod file: https://lkml.org/lkml/2019/5/13/991 drivers/net/phy/asix.ko and drivers/net/usb/asix.ko have the same basename, and there is a race in generating .tmp_versions/asix.mod Kbuild has