Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 4:03 PM, Kees Cook wrote: > On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: >> Hi Kees, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on linus/master] >> [also build test ERROR on v4.16-rc2

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 4:03 PM, Kees Cook wrote: > On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: >> Hi Kees, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on linus/master] >> [also build test ERROR on v4.16-rc2 next-20180222] >> [if your patch is

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: > Hi Kees, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.16-rc2 next-20180222] > [if your patch is applied to the wrong git tree, please drop us

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 2:26 PM, kbuild test robot wrote: > Hi Kees, > > I love your patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.16-rc2 next-20180222] > [if your patch is applied to the wrong git tree, please drop us a note to >

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Maciej S. Szmigiero
On 22.02.2018 01:28, Kees Cook wrote: > The header files for some structures could get included in such a way > that struct attributes (specifically __randomize_layout from path.h) would > be parsed as variable names instead of attributes. This could lead to > some instances of a structure being

Re: [PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Maciej S. Szmigiero
On 22.02.2018 01:28, Kees Cook wrote: > The header files for some structures could get included in such a way > that struct attributes (specifically __randomize_layout from path.h) would > be parsed as variable names instead of attributes. This could lead to > some instances of a structure being

[PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-21 Thread Kees Cook
The header files for some structures could get included in such a way that struct attributes (specifically __randomize_layout from path.h) would be parsed as variable names instead of attributes. This could lead to some instances of a structure being unrandomized, causing nasty GPFs, etc. This

[PATCH v2] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-21 Thread Kees Cook
The header files for some structures could get included in such a way that struct attributes (specifically __randomize_layout from path.h) would be parsed as variable names instead of attributes. This could lead to some instances of a structure being unrandomized, causing nasty GPFs, etc. This