Re:Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

2019-06-23 Thread Tiezhu Yang
At 2019-06-24 09:53:59, "Dave Young" wrote: >On 06/24/19 at 09:35am, Dave Young wrote: >> On 06/23/19 at 06:24am, Tiezhu Yang wrote: >> > Fix the following sparse warning: >> > >> > arch/x86/kernel/crash.c:59:15: >> > warning: symbol 'crash_zero_bytes' was not declared. Should it be static? >> >

Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

2019-06-23 Thread Dave Young
On 06/24/19 at 09:35am, Dave Young wrote: > On 06/23/19 at 06:24am, Tiezhu Yang wrote: > > Fix the following sparse warning: > > > > arch/x86/kernel/crash.c:59:15: > > warning: symbol 'crash_zero_bytes' was not declared. Should it be static? > > > > First, make crash_zero_bytes static. In

Re: [PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

2019-06-23 Thread Dave Young
On 06/23/19 at 06:24am, Tiezhu Yang wrote: > Fix the following sparse warning: > > arch/x86/kernel/crash.c:59:15: > warning: symbol 'crash_zero_bytes' was not declared. Should it be static? > > First, make crash_zero_bytes static. In addition, crash_zero_bytes > is used when CONFIG_KEXEC_FILE is

[PATCH v2] kexec: fix warnig of crash_zero_bytes in crash.c

2019-06-22 Thread Tiezhu Yang
Fix the following sparse warning: arch/x86/kernel/crash.c:59:15: warning: symbol 'crash_zero_bytes' was not declared. Should it be static? First, make crash_zero_bytes static. In addition, crash_zero_bytes is used when CONFIG_KEXEC_FILE is set, so make it only available under CONFIG_KEXEC_FILE.