Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-06 Thread YU Bo
On Tue, Nov 06, 2018 at 09:09:15AM +0100, Rafael J. Wysocki wrote: On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > >

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-06 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 8:58 AM Joe Perches wrote: > > On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > > > Signed-off-by: Bo YU > > > > First off, IMO, you shoul

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Joe Perches
On Tue, 2018-11-06 at 08:49 +0100, Rafael J. Wysocki wrote: > On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > > > Signed-off-by: Bo YU > > First off, IMO, you should not change the existing code just in order > to make checkpatch

Re: [PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Rafael J. Wysocki
On Tue, Nov 6, 2018 at 3:42 AM Bo YU wrote: > > Fix warning form checkpatch, use pr_warn replace KERN_WARNING > > Signed-off-by: Bo YU First off, IMO, you should not change the existing code just in order to make checkpatch happy about it. That alone is not a good enough reason for modifying it

[PATCH v2] kobject: to use pr_warn replace KERN_WARNING

2018-11-05 Thread Bo YU
Fix warning form checkpatch, use pr_warn replace KERN_WARNING Signed-off-by: Bo YU --- changes in v2: According to Joe's suggestion,drop newline from msg, otherwise it can be unterminated with newline. --- lib/kobject_uevent.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) di