Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-11-25 Thread Pavel Machek
Hi! > > From the perspective of Linux you see the two control banks as 2 LED > >class devices (because you are setting brightness for control banks, > >not for the LED strips). > > The way Marek explains it is correct and the way I wrote the driver > intially.  There is no direct control of the

Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-10-12 Thread Dan Murphy
Pavel On 10/10/20 4:50 PM, Marek Behun wrote: On Sat, 10 Oct 2020 20:57:00 +0200 Pavel Machek wrote: On Fri 2020-10-09 15:51:35, Gabriel David wrote: The mentioned struct, lm3697_led, was renamed to lm3697_bank since the structure is representing the control banks. This name, in my opinion,

Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-10-10 Thread Marek Behun
On Sat, 10 Oct 2020 20:57:00 +0200 Pavel Machek wrote: > On Fri 2020-10-09 15:51:35, Gabriel David wrote: > > The mentioned struct, lm3697_led, was renamed to lm3697_bank since the > > structure is representing the control banks. This name, in my opinion, > > is more semantically correct. The

Re: [PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-10-10 Thread Pavel Machek
On Fri 2020-10-09 15:51:35, Gabriel David wrote: > The mentioned struct, lm3697_led, was renamed to lm3697_bank since the > structure is representing the control banks. This name, in my opinion, > is more semantically correct. The pointers referring to it were also > renamed. > Signed-off-by:

[PATCH v2] leds: lm3697: Rename struct into more appropriate name

2020-10-09 Thread Gabriel David
The mentioned struct, lm3697_led, was renamed to lm3697_bank since the structure is representing the control banks. This name, in my opinion, is more semantically correct. The pointers referring to it were also renamed. Signed-off-by: Gabriel David --- Yes, this is the same Gabriel David from