Re: [PATCH v2] media: cx18, ivtv: eliminate unnecessary array index checks

2013-01-06 Thread Andy Walls
Nickolai Zeldovich wrote: >The idx values passed to cx18_i2c_register() and ivtv_i2c_register() >by cx18_init_subdevs() and ivtv_load_and_init_modules() respectively >are always in-range, based on how the hw_all bitmask is populated. >Previously, the checks were already ineffective because

[PATCH v2] media: cx18, ivtv: eliminate unnecessary array index checks

2013-01-06 Thread Nickolai Zeldovich
The idx values passed to cx18_i2c_register() and ivtv_i2c_register() by cx18_init_subdevs() and ivtv_load_and_init_modules() respectively are always in-range, based on how the hw_all bitmask is populated. Previously, the checks were already ineffective because arrays were being dereferenced using

[PATCH v2] media: cx18, ivtv: eliminate unnecessary array index checks

2013-01-06 Thread Nickolai Zeldovich
The idx values passed to cx18_i2c_register() and ivtv_i2c_register() by cx18_init_subdevs() and ivtv_load_and_init_modules() respectively are always in-range, based on how the hw_all bitmask is populated. Previously, the checks were already ineffective because arrays were being dereferenced using

Re: [PATCH v2] media: cx18, ivtv: eliminate unnecessary array index checks

2013-01-06 Thread Andy Walls
Nickolai Zeldovich nicko...@csail.mit.edu wrote: The idx values passed to cx18_i2c_register() and ivtv_i2c_register() by cx18_init_subdevs() and ivtv_load_and_init_modules() respectively are always in-range, based on how the hw_all bitmask is populated. Previously, the checks were already