Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-09 Thread Ulf Hansson
[...] >>> Then you need to remove the hw_reset test from mmc_test. Refer: >>> >>> http://marc.info/?l=linux-mmc=144360165906544=2 >>> >> >> I realize that the test becomes a bit different, but I don't think it's >> useless. >> >> If we add a check for MMC_CAP_HW_RESET and verify that

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-09 Thread Adrian Hunter
On 08/10/15 16:35, Ulf Hansson wrote: > On 8 October 2015 at 15:03, Adrian Hunter wrote: >> On 08/10/15 13:59, Ulf Hansson wrote: >>> On 8 October 2015 at 09:09, Chaotian Jing >>> wrote: Suppose that we got a data crc error, and it triggers the mmc_reset. mmc_reset will call

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-09 Thread Ulf Hansson
[...] >>> Then you need to remove the hw_reset test from mmc_test. Refer: >>> >>> http://marc.info/?l=linux-mmc=144360165906544=2 >>> >> >> I realize that the test becomes a bit different, but I don't think it's >> useless. >> >> If we add a check for MMC_CAP_HW_RESET and verify that

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-09 Thread Adrian Hunter
On 08/10/15 16:35, Ulf Hansson wrote: > On 8 October 2015 at 15:03, Adrian Hunter wrote: >> On 08/10/15 13:59, Ulf Hansson wrote: >>> On 8 October 2015 at 09:09, Chaotian Jing >>> wrote: Suppose that we got a data crc error, and it

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Ulf Hansson
On 8 October 2015 at 15:03, Adrian Hunter wrote: > On 08/10/15 13:59, Ulf Hansson wrote: >> On 8 October 2015 at 09:09, Chaotian Jing wrote: >>> Suppose that we got a data crc error, and it triggers the mmc_reset. >>> mmc_reset will call mmc_send_status to see if HW reset was supported. >>>

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Adrian Hunter
On 08/10/15 13:59, Ulf Hansson wrote: > On 8 October 2015 at 09:09, Chaotian Jing wrote: >> Suppose that we got a data crc error, and it triggers the mmc_reset. >> mmc_reset will call mmc_send_status to see if HW reset was supported. >> before issue CMD13, it will do retune, and if EMMC was in

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Ulf Hansson
On 8 October 2015 at 09:09, Chaotian Jing wrote: > Suppose that we got a data crc error, and it triggers the mmc_reset. > mmc_reset will call mmc_send_status to see if HW reset was supported. > before issue CMD13, it will do retune, and if EMMC was in HS400 mode, > it will reduce frequency to

[PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Chaotian Jing
Suppose that we got a data crc error, and it triggers the mmc_reset. mmc_reset will call mmc_send_status to see if HW reset was supported. before issue CMD13, it will do retune, and if EMMC was in HS400 mode, it will reduce frequency to 52Mhz firstly, then results in card init was doing at 52Mhz.

[PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Chaotian Jing
Suppose that we got a data crc error, and it triggers the mmc_reset. mmc_reset will call mmc_send_status to see if HW reset was supported. before issue CMD13, it will do retune, and if EMMC was in HS400 mode, it will reduce frequency to 52Mhz firstly, then results in card init was doing at 52Mhz.

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Ulf Hansson
On 8 October 2015 at 09:09, Chaotian Jing wrote: > Suppose that we got a data crc error, and it triggers the mmc_reset. > mmc_reset will call mmc_send_status to see if HW reset was supported. > before issue CMD13, it will do retune, and if EMMC was in HS400 mode, > it

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Ulf Hansson
On 8 October 2015 at 15:03, Adrian Hunter wrote: > On 08/10/15 13:59, Ulf Hansson wrote: >> On 8 October 2015 at 09:09, Chaotian Jing wrote: >>> Suppose that we got a data crc error, and it triggers the mmc_reset. >>> mmc_reset will call

Re: [PATCH v2] mmc: core: Fix init_card in 52Mhz

2015-10-08 Thread Adrian Hunter
On 08/10/15 13:59, Ulf Hansson wrote: > On 8 October 2015 at 09:09, Chaotian Jing wrote: >> Suppose that we got a data crc error, and it triggers the mmc_reset. >> mmc_reset will call mmc_send_status to see if HW reset was supported. >> before issue CMD13, it will do