Re: [PATCH v2] net/smc: fix TCP fallback socket release

2018-12-18 Thread Ursula Braun
On 12/18/2018 08:03 AM, Myungho Jung wrote: > On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote: >> > > Hi Ursula, > > Thank you for your suggestion. I have a question on your comment. > >> >> On 12/17/2018 06:21 AM, Myungho Jung wrote: >>> clcsock can be released while

Re: [PATCH v2] net/smc: fix TCP fallback socket release

2018-12-17 Thread Myungho Jung
On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote: > Hi Ursula, Thank you for your suggestion. I have a question on your comment. > > On 12/17/2018 06:21 AM, Myungho Jung wrote: > > clcsock can be released while kernel_accept() references it in TCP > > listen worker. Also, clcsock

Re: [PATCH v2] net/smc: fix TCP fallback socket release

2018-12-17 Thread Ursula Braun
On 12/17/2018 06:21 AM, Myungho Jung wrote: > clcsock can be released while kernel_accept() references it in TCP > listen worker. Also, clcsock needs to wake up before released if TCP > fallback is used and the clcsock is blocked by accept. Add a lock to > safely release clcsock and call

[PATCH v2] net/smc: fix TCP fallback socket release

2018-12-16 Thread Myungho Jung
clcsock can be released while kernel_accept() references it in TCP listen worker. Also, clcsock needs to wake up before released if TCP fallback is used and the clcsock is blocked by accept. Add a lock to safely release clcsock and call kernel_sock_shutdown() to wake up clcsock from accept in