Re: [PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-25 Thread Dmitry Vyukov
On Thu, Mar 25, 2021 at 9:46 AM Eric Dumazet wrote: > > On Thu, Mar 25, 2021 at 8:39 AM Dmitry Vyukov wrote: > > > > On Wed, Mar 24, 2021 at 10:40 AM Eric Dumazet wrote: > > > > > > On Tue, Mar 23, 2021 at 7:49 AM Dmitry Vyukov wrote: > > > > > > > > netdev_wait_allrefs() issues a warning if

Re: [PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-25 Thread Eric Dumazet
On Thu, Mar 25, 2021 at 8:39 AM Dmitry Vyukov wrote: > > On Wed, Mar 24, 2021 at 10:40 AM Eric Dumazet wrote: > > > > On Tue, Mar 23, 2021 at 7:49 AM Dmitry Vyukov wrote: > > > > > > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > > > after 10 seconds. While 10 second

Re: [PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-25 Thread Dmitry Vyukov
On Wed, Mar 24, 2021 at 10:40 AM Eric Dumazet wrote: > > On Tue, Mar 23, 2021 at 7:49 AM Dmitry Vyukov wrote: > > > > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > > after 10 seconds. While 10 second wait generally should not happen > > under normal workload in normal

Re: [PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-24 Thread Eric Dumazet
On Tue, Mar 23, 2021 at 7:49 AM Dmitry Vyukov wrote: > > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > after 10 seconds. While 10 second wait generally should not happen > under normal workload in normal environment, it seems to fire falsely > very often during fuzzing

Re: [PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-24 Thread Leon Romanovsky
On Tue, Mar 23, 2021 at 07:49:23AM +0100, Dmitry Vyukov wrote: > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > after 10 seconds. While 10 second wait generally should not happen > under normal workload in normal environment, it seems to fire falsely > very often during

[PATCH v2] net: make unregister netdev warning timeout configurable

2021-03-23 Thread Dmitry Vyukov
netdev_wait_allrefs() issues a warning if refcount does not drop to 0 after 10 seconds. While 10 second wait generally should not happen under normal workload in normal environment, it seems to fire falsely very often during fuzzing and/or in qemu emulation (~10x slower). At least it's not