Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-10 Thread Mike Kravetz
On 6/10/20 7:17 PM, Al Viro wrote: > On Wed, Jun 10, 2020 at 06:36:16PM -0700, Matthew Wilcox wrote: > >> while (file->f_mode & FMODE_OVL_UPPER) >> file = file->private_data; >> return file; >> >> Or are you proposing that overlayfs copy FMODE_HUGEPAGES from the >>

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-10 Thread Al Viro
On Wed, Jun 10, 2020 at 06:36:16PM -0700, Matthew Wilcox wrote: > while (file->f_mode & FMODE_OVL_UPPER) > file = file->private_data; > return file; > > Or are you proposing that overlayfs copy FMODE_HUGEPAGES from the > underlying fs to the overlaying fs? The latter -

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-10 Thread Matthew Wilcox
On Thu, Jun 11, 2020 at 01:37:26AM +0100, Al Viro wrote: > On Wed, Jun 10, 2020 at 05:13:52PM -0700, Mike Kravetz wrote: > > > To address this issue, > > - Add a new file operation f_real while will return the underlying file. > > Only overlayfs provides a function for this operation. > > - Add

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-10 Thread Al Viro
On Wed, Jun 10, 2020 at 05:13:52PM -0700, Mike Kravetz wrote: > To address this issue, > - Add a new file operation f_real while will return the underlying file. > Only overlayfs provides a function for this operation. > - Add a new routine real_file() which can be used by core code get an >

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-10 Thread Mike Kravetz
On 6/4/20 2:16 AM, Miklos Szeredi wrote: > On Thu, May 28, 2020 at 11:01 PM Mike Kravetz wrote: >> >> Well yuck! get_unmapped_area is not part of mm_struct if !CONFIG_MMU. >> >> Miklos, would adding '#ifdef CONFIG_MMU' around the overlayfs code be too >> ugly for you? Another option is to use

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-06-04 Thread Miklos Szeredi
On Thu, May 28, 2020 at 11:01 PM Mike Kravetz wrote: > > On 5/28/20 1:37 AM, kbuild test robot wrote: > > Hi Mike, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on miklos-vfs/overlayfs-next] > > [also build test ERROR on linus/master v5.7-rc7] > > [cannot

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-05-28 Thread Mike Kravetz
On 5/28/20 1:37 AM, kbuild test robot wrote: > Hi Mike, > > I love your patch! Yet something to improve: > > [auto build test ERROR on miklos-vfs/overlayfs-next] > [also build test ERROR on linus/master v5.7-rc7] > [cannot apply to linux/master next-20200526] > [if your patch is applied to the

Re: [PATCH v2] ovl: provide real_file() and overlayfs get_unmapped_area()

2020-05-28 Thread kbuild test robot
Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on miklos-vfs/overlayfs-next] [also build test ERROR on linus/master v5.7-rc7] [cannot apply to linux/master next-20200526] [if your patch is applied to the wrong git tree, please drop us a note to help improve the