Re: [PATCH v2] perf annotate/report: Remove hist__account_cycles from callback

2019-03-15 Thread Jin, Yao
On 3/15/2019 8:54 PM, Jiri Olsa wrote: On Fri, Mar 15, 2019 at 09:46:01PM +0800, Jin Yao wrote: The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already walks on all branch entries. This patch

Re: [PATCH v2] perf annotate/report: Remove hist__account_cycles from callback

2019-03-15 Thread Jiri Olsa
On Fri, Mar 15, 2019 at 09:46:01PM +0800, Jin Yao wrote: > The hist__account_cycles is executed when the hist_iter__branch_callback > is called. But it looks it's not necessary. In hist__account_cycles, it > already walks on all branch entries. > > This patch moves the hist__account_cycles out of

[PATCH v2] perf annotate/report: Remove hist__account_cycles from callback

2019-03-14 Thread Jin Yao
The hist__account_cycles is executed when the hist_iter__branch_callback is called. But it looks it's not necessary. In hist__account_cycles, it already walks on all branch entries. This patch moves the hist__account_cycles out of callback, now the data processing is much faster than before.