Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/18/19 4:29 PM, Tony Jones wrote: > I'd been simultaneously working on a patch set to fix up Python3. > > It's actually already in our Factory and SLE15-SP1 releases as we had a > deadline to kill Python2 usage for internal rpms. > > I was going to post once I'd fixed the last remaining

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/17/19 1:45 AM, Seeteena Thoufeek wrote: > - print "vec=%s\n" % \ > - (symbol_str("irq__softirq_entry", "vec", vec)), > + print("vec=%s\n" % \ > + (symbol_str("irq__softirq_entry", "vec", vec))), Again, check the trailing comma usage: $ echo

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-18 Thread Tony Jones
On 1/17/19 4:32 AM, Jiri Olsa wrote: > On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote: >> Support both Python 2 and Python 3 in check-perf-trace.py. >> ``print`` is now a function rather than a statement. This should have >> no functional change. >> >> Fix indentation issue,

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-17 Thread Ravi Bangoria
Hi Seeteena, Jiri, On 1/17/19 6:02 PM, Jiri Olsa wrote: > On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote: >> Support both Python 2 and Python 3 in check-perf-trace.py. >> ``print`` is now a function rather than a statement. This should have >> no functional change. >> >> Fix

Re: [PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-17 Thread Jiri Olsa
On Thu, Jan 17, 2019 at 03:15:28PM +0530, Seeteena Thoufeek wrote: > Support both Python 2 and Python 3 in check-perf-trace.py. > ``print`` is now a function rather than a statement. This should have > no functional change. > > Fix indentation issue, replace spaces with tab > > Signed-off-by:

[PATCH v2] perf scripts python: Add Python 3 support to check-perf-trace.py

2019-01-17 Thread Seeteena Thoufeek
Support both Python 2 and Python 3 in check-perf-trace.py. ``print`` is now a function rather than a statement. This should have no functional change. Fix indentation issue, replace spaces with tab Signed-off-by: Seeteena Thoufeek Reviewed-by: Ravi Bangoria ---