Re: [PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-29 Thread Linus Walleij
On Wed, Aug 22, 2018 at 6:57 PM Daniel Kurtz wrote: > Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts") > changed to the clearing of interrupt status bits to a RMW in a critical > section. This works, but is a bit overkill. > > The relevant interrupt/wake status bits are in

Re: [PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-29 Thread Linus Walleij
On Wed, Aug 22, 2018 at 6:57 PM Daniel Kurtz wrote: > Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts") > changed to the clearing of interrupt status bits to a RMW in a critical > section. This works, but is a bit overkill. > > The relevant interrupt/wake status bits are in

Re: [PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-23 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pinctrl/devel] [also build test WARNING on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-23 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pinctrl/devel] [also build test WARNING on v4.18 next-20180822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-22 Thread Daniel Kurtz
Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts") changed to the clearing of interrupt status bits to a RMW in a critical section. This works, but is a bit overkill. The relevant interrupt/wake status bits are in the Most Significant Byte of a 32-bit word. These two are the

[PATCH v2] pinctrl/amd: use byte access to clear irq/wake status bits

2018-08-22 Thread Daniel Kurtz
Commit 6afb10267c1692 ("pinctrl/amd: fix masking of GPIO interrupts") changed to the clearing of interrupt status bits to a RMW in a critical section. This works, but is a bit overkill. The relevant interrupt/wake status bits are in the Most Significant Byte of a 32-bit word. These two are the