Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Hans de Goede
Hi, On 4/10/21 8:56 AM, Guenter Roeck wrote: > On 4/8/21 11:02 PM, Thomas Weißschuh wrote: >> On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >>> On 4/8/21 2:36 AM, Hans de Goede wrote: On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote:

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/8/21 11:02 PM, Thomas Weißschuh wrote: > On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: >> On 4/8/21 2:36 AM, Hans de Goede wrote: >>> On 4/7/21 9:43 PM, Thomas Weißschuh wrote: On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >>> Jean, Guenter, >>> >>> Thomas has been working on a

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-10 Thread Guenter Roeck
On 4/8/21 9:07 AM, Hans de Goede wrote: > Hi Guenter, > > On 4/8/21 5:08 PM, Guenter Roeck wrote: >> On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >>> Changes since v1: >>> * Incorporate feedback from Barnabás Pőcze >>> * Use a WMI driver instead of a platform driver >>> *

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-09 Thread Thomas Weißschuh
On Do, 2021-04-08T08:00-0700, Guenter Roeck wrote: > On 4/8/21 2:36 AM, Hans de Goede wrote: > > On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > >> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: > > Jean, Guenter, > > > > Thomas has been working on a WMI driver to expose various motherboard > >

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi Guenter, On 4/8/21 5:08 PM, Guenter Roeck wrote: > On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: >> Changes since v1: >> * Incorporate feedback from Barnabás Pőcze >> * Use a WMI driver instead of a platform driver >> * Let the kernel manage the driver lifecycle >> *

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Guenter Roeck
On Mon, Apr 05, 2021 at 10:48:10PM +0200, Thomas Weißschuh wrote: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource cleanup >

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Guenter Roeck
On 4/8/21 2:36 AM, Hans de Goede wrote: > Hi, > > On 4/7/21 9:43 PM, Thomas Weißschuh wrote: >> Hi Hans, >> >> On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >>> Thank you for your new driver and thank you for the quick respin >>> addressing Barnabás' request to make it a WMI driver. >>> >>>

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Thomas Weißschuh
Hi Hans, On Do, 2021-04-08T11:36+0200, Hans de Goede wrote: > On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > > Hi Hans, > > > > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: > >> Thank you for your new driver and thank you for the quick respin > >> addressing Barnabás' request to make it a

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Thomas Weißschuh
Hi, On Mi, 2021-04-07T18:27+, Barnabás Pőcze wrote: > 2021. április 5., hétfő 22:48 keltezéssel, Thomas Weißschuh írta: > > Tested with a X570 I Aorus Pro Wifi. > > The mainboard contains an ITE IT8688E chip for management. > > This chips is also handled by drivers/hwmon/i87.c but as it is

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-08 Thread Hans de Goede
Hi, On 4/7/21 9:43 PM, Thomas Weißschuh wrote: > Hi Hans, > > On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: >> Thank you for your new driver and thank you for the quick respin >> addressing Barnabás' request to make it a WMI driver. >> >> The code looks good, so merging this should be a

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-07 Thread Thomas Weißschuh
Hi Hans, On Mi, 2021-04-07T17:54+0200, Hans de Goede wrote: > Thank you for your new driver and thank you for the quick respin > addressing Barnabás' request to make it a WMI driver. > > The code looks good, so merging this should be a no-brainer, > yet I'm not sure if I should merge this driver

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-07 Thread Barnabás Pőcze
Hi 2021. április 5., hétfő 22:48 keltezéssel, Thomas Weißschuh írta: > Changes since v1: > * Incorporate feedback from Barnabás Pőcze > * Use a WMI driver instead of a platform driver > * Let the kernel manage the driver lifecycle > * Fix errno/ACPI error confusion > * Fix resource

Re: [PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-07 Thread Hans de Goede
Hi Thomas, Thank you for your new driver and thank you for the quick respin addressing Barnabás' request to make it a WMI driver. The code looks good, so merging this should be a no-brainer, yet I'm not sure if I should merge this driver as-is, let me explain. The problem is that I assume that

[PATCH v2] platform/x86: add Gigabyte WMI temperature driver

2021-04-05 Thread Thomas Weißschuh
Changes since v1: * Incorporate feedback from Barnabás Pőcze * Use a WMI driver instead of a platform driver * Let the kernel manage the driver lifecycle * Fix errno/ACPI error confusion * Fix resource cleanup * Document reason for integer casting Thank you Barnabás for your review, it