Re: [PATCH v2] resource: make sure requested range is included in the root range

2012-07-13 Thread Bjorn Helgaas
On Fri, Jul 13, 2012 at 2:38 AM, Octavian Purdila wrote: > On Thu, Jul 12, 2012 at 10:02 PM, Bjorn Helgaas wrote: > >> Why don't you fix this right where the problem occurs, in >> __reserve_region_with_split(), with something like this: >> >> if (end > conflict->start && conflict->start >

Re: [PATCH v2] resource: make sure requested range is included in the root range

2012-07-13 Thread Octavian Purdila
On Thu, Jul 12, 2012 at 10:02 PM, Bjorn Helgaas wrote: > Why don't you fix this right where the problem occurs, in > __reserve_region_with_split(), with something like this: > > if (end > conflict->start && conflict->start > start) > __reserve_region_with_split(root, start

Re: [PATCH v2] resource: make sure requested range is included in the root range

2012-07-12 Thread Bjorn Helgaas
On Thu, Jul 12, 2012 at 11:27 AM, Octavian Purdila wrote: > When the requested range is outside of the root range the logic in > __reserve_region_with_split will cause an infinite recursion which > will overflow the stack as seen in the warning bellow. I think reserve_region_with_split() is a dub

[PATCH v2] resource: make sure requested range is included in the root range

2012-07-12 Thread Octavian Purdila
When the requested range is outside of the root range the logic in __reserve_region_with_split will cause an infinite recursion which will overflow the stack as seen in the warning bellow. This particular stack overflow was caused by requesting the (1-107ff) range while the root range