Re: [PATCH v2] serial/arc-uart: Add new driver

2012-10-03 Thread Vineet Gupta
On Tuesday 02 October 2012 05:17 PM, Alan Cox wrote: >> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) >> */ +int __attribute__((weak)) running_on_iss; > Why not pass a quirks field in your platform data instead - much > cleaner than a global. I'd thought about it too.

Re: [PATCH v2] serial/arc-uart: Add new driver

2012-10-03 Thread Vineet Gupta
On Tuesday 02 October 2012 05:17 PM, Alan Cox wrote: +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) */ +int __attribute__((weak)) running_on_iss; Why not pass a quirks field in your platform data instead - much cleaner than a global. I'd thought about it too. However

Re: [PATCH v2] serial/arc-uart: Add new driver

2012-10-02 Thread Alan Cox
> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) > */ +int __attribute__((weak)) running_on_iss; Why not pass a quirks field in your platform data instead - much cleaner than a global. > +static void arc_serial_set_ldisc(struct uart_port *port, int ld) > +{ > +} If you

Re: [PATCH v2] serial/arc-uart: Add new driver

2012-10-02 Thread Alan Cox
+/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) */ +int __attribute__((weak)) running_on_iss; Why not pass a quirks field in your platform data instead - much cleaner than a global. +static void arc_serial_set_ldisc(struct uart_port *port, int ld) +{ +} If you don't

[PATCH v2] serial/arc-uart: Add new driver

2012-10-01 Thread Vineet.Gupta1
From: Vineet Gupta Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x v2: * ttyARC used as device name * Dynamic assignment of major/minor numbers. * Ref counting tty in rx routine to prevent it from disappearing in case of a hangup *

[PATCH v2] serial/arc-uart: Add new driver

2012-10-01 Thread Vineet.Gupta1
From: Vineet Gupta vgu...@synopsys.com Driver for non-standard on-chip UART, instantiated in the ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x v2: * ttyARC used as device name * Dynamic assignment of major/minor numbers. * Ref counting tty in rx routine to prevent it from disappearing in