Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-21 Thread Russell King - ARM Linux
On Sat, Apr 20, 2013 at 12:33:45PM +0200, Arnd Bergmann wrote: > @@ -315,6 +325,7 @@ static void pl011_dma_probe_initcall(struct > uart_amba_port *uap) > struct dma_uap { > struct list_head node; > struct uart_amba_port *uap; > + struct device *dev; There is really no need for

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-21 Thread Russell King - ARM Linux
On Sat, Apr 20, 2013 at 12:33:45PM +0200, Arnd Bergmann wrote: @@ -315,6 +325,7 @@ static void pl011_dma_probe_initcall(struct uart_amba_port *uap) struct dma_uap { struct list_head node; struct uart_amba_port *uap; + struct device *dev; There is really no need for this.

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-20 Thread Arnd Bergmann
Hi Lee and Russell, While going through the arm-soc tree yesterday, I noticed two things: * I had already done a patch for this in January which I meant to queue up for 3.10, as it is needed to make spear13xx use the dma-engine binding * I actually forgot to merge that branch into for-next :(

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-20 Thread Arnd Bergmann
Hi Lee and Russell, While going through the arm-soc tree yesterday, I noticed two things: * I had already done a patch for this in January which I meant to queue up for 3.10, as it is needed to make spear13xx use the dma-engine binding * I actually forgot to merge that branch into for-next :(

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 09:39:22AM +0100, Lee Jones wrote: > On Thu, 18 Apr 2013, Russell King - ARM Linux wrote: > > This suffers the same problem with your MMCI patch. If you're using DT and > > don't provide the DMA information, you get errors printed. That's not on > > for an optional driver

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Lee Jones
On Thu, 18 Apr 2013, Russell King - ARM Linux wrote: > On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote: > > @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct > > uart_amba_port *uap) > > dma_cap_zero(mask); > > dma_cap_set(DMA_SLAVE, mask); > > > > - chan =

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote: > @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct > uart_amba_port *uap) > dma_cap_zero(mask); > dma_cap_set(DMA_SLAVE, mask); > > - chan = dma_request_channel(mask, plat->dma_filter,

[PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Lee Jones
The new DMA API is operational. It is now possible to request DMA channels from information passed via Device Tree. Cc: Russell King Cc: Greg Kroah-Hartman Cc: Jiri Slaby Signed-off-by: Lee Jones --- drivers/tty/serial/amba-pl011.c | 19 +-- 1 file changed, 13

[PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Lee Jones
The new DMA API is operational. It is now possible to request DMA channels from information passed via Device Tree. Cc: Russell King li...@arm.linux.org.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote: @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct uart_amba_port *uap) dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); - chan = dma_request_channel(mask, plat-dma_filter, plat-dma_tx_param); +

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Lee Jones
On Thu, 18 Apr 2013, Russell King - ARM Linux wrote: On Thu, Apr 18, 2013 at 09:14:16AM +0100, Lee Jones wrote: @@ -269,7 +270,10 @@ static void pl011_dma_probe_initcall(struct uart_amba_port *uap) dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask); - chan =

Re: [PATCH v2] serial: pl011: Add Device Tree support to request DMA channels

2013-04-18 Thread Russell King - ARM Linux
On Thu, Apr 18, 2013 at 09:39:22AM +0100, Lee Jones wrote: On Thu, 18 Apr 2013, Russell King - ARM Linux wrote: This suffers the same problem with your MMCI patch. If you're using DT and don't provide the DMA information, you get errors printed. That's not on for an optional driver