Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-28 Thread Florian Fainelli
On 11/24/18 6:52 AM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node returned by it > and that reference needs to be dropped by its caller. soc_is_brcmstb() > doesn't do that, so fix it. > > [treding: slightly rewrite to avoid inline comparison] > > Signed-off-by: Y

Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-27 Thread Florian Fainelli
On 11/26/18 6:42 AM, Frank Lee wrote: > On Sat, Nov 24, 2018 at 10:52 PM Yangtao Li wrote: >> >> of_find_node_by_path() acquires a reference to the node returned by it >> and that reference needs to be dropped by its caller. soc_is_brcmstb() >> doesn't do that, so fix it. >> >> [treding: slight

Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-26 Thread Frank Lee
On Sat, Nov 24, 2018 at 10:52 PM Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node returned by it > and that reference needs to be dropped by its caller. soc_is_brcmstb() > doesn't do that, so fix it. > > [treding: slightly rewrite to avoid inline comparison] > > Signed

[PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-24 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. soc_is_brcmstb() doesn't do that, so fix it. [treding: slightly rewrite to avoid inline comparison] Signed-off-by: Yangtao Li --- Changes in v2: -update changelog -slightl